[PATCH] bw-qcam: adds parameter aggressive to skip passive detection and directly attempt initialization

[PATCH] bw-qcam: adds parameter aggressive to skip passive detection and directly attempt initialization

[Brett T. Warden]

---

diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam.c
index 5842352..b74a9cb 100644
--- a/drivers/media/video/bw-qcam.c
+++ b/drivers/media/video/bw-qcam.c
@@ -82,11 +82,16 @@ OTHER DEALINGS IN THE SOFTWARE.
 static unsigned int maxpoll=250;   /* Maximum busy-loop count for qcam I/O */
 static unsigned int yieldlines=4;  /* Yield after this many during capture */
 static int video_nr = -1;
+static unsigned int aggressive;		/* Whether to probe aggressively */
 
 module_param(maxpoll, int, 0);
 module_param(yieldlines, int, 0);
 module_param(video_nr, int, 0);
 
+/* Set aggressive=1 to avoid detection by polling status register and
+ * immediately attempt to initialize qcam */
+module_param(aggressive, int, 0);
+
 static inline int read_lpstatus(struct qcam_device *q)
 {
 	return parport_read_status(q->pport);
@@ -331,6 +336,9 @@ static int qc_detect(struct qcam_device *q)
 	int count = 0;
 	int i;
 
+	if (aggressive)
+		return 1;
+
 	lastreg = reg = read_lpstatus(q) & 0xf0;
 
 	for (i = 0; i < 500; i++)
@@ -354,12 +362,12 @@ static int qc_detect(struct qcam_device *q)
 
 	/* Be (even more) liberal in what you accept...  */
 
-/*	if (count > 30 && count < 200) */
 	if (count > 20 && count < 400) {
 		return 1;	/* found */
 	} else {
 		printk(KERN_ERR "No Quickcam found on port %s\n",
 			q->pport->name);
+		printk(KERN_DEBUG "Quickcam detection counter: %u\n", count);
 		return 0;	/* not found */
 	}
 }

Re: [PATCH] bw-qcam: adds parameter aggressive to skip passive detection and directly attempt initialization

[Alan Cox]

On Tue,  4 Dec 2007 16:14:13 -0800
"Brett T. Warden" <brett.warden@gmail.com> wrote:

> ---
> 
> diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam.c
> index 5842352..b74a9cb 100644
> --- a/drivers/media/video/bw-qcam.c
> +++ b/drivers/media/video/bw-qcam.c
> @@ -82,11 +82,16 @@ OTHER DEALINGS IN THE SOFTWARE.
>  static unsigned int maxpoll=250;   /* Maximum busy-loop count for qcam I/O */
>  static unsigned int yieldlines=4;  /* Yield after this many during capture */
>  static int video_nr = -1;
> +static unsigned int aggressive;	

Acked-by: Alan Cox <alan@redhat.com>

Although I would suggest that "aggressive" may not be the best term - I'm
not such of a good one however - skip_passive ?

Re: [PATCH] bw-qcam: adds parameter aggressive to skip passive detection and directly attempt initialization

[Brett Warden]

On Dec 5, 2007 9:37 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> Although I would suggest that "aggressive" may not be the best term - I'm
> not such of a good one however - skip_passive ?

How about force_init?

-- 
Brett Warden

Re: [PATCH] bw-qcam: adds parameter aggressive to skip passive detection and directly attempt initialization

[Bill Davidsen]

Brett Warden wrote:
> On Dec 5, 2007 9:37 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> 
>> Although I would suggest that "aggressive" may not be the best term - I'm
>> not such of a good one however - skip_passive ?
> 
> How about force_init?
> 
Much more descriptive.


-- 
Bill Davidsen <davidsen@tmr.com>
   "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot