* [PATCH] SCSI: make pcmcia directory use obj-y|m instead of subdir-y|m
@ 2007-12-07 13:36 Tejun Heo
2007-12-07 16:06 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2007-12-07 13:36 UTC (permalink / raw)
To: Sam Ravnborg, Linux Kernel, linux-scsi, James Bottomley
subdir-y|m isn't supposed to contain modules or built-in components.
Change subdir-$(CONFIG_PCMCIA) to obj-$(CONFIG_PCMCIA).
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: James Bottomley <James.Bottomley@SteelEye.com>
---
drivers/scsi/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 2e6129f..72c8d2e 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -18,7 +18,7 @@ CFLAGS_aha152x.o = -DAHA152X_STAT -DAUTOCONF
CFLAGS_gdth.o = # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS
CFLAGS_seagate.o = -DARBITRATE -DPARITY -DSEAGATE_USE_ASM
-subdir-$(CONFIG_PCMCIA) += pcmcia
+obj-$(CONFIG_PCMCIA) += pcmcia/
obj-$(CONFIG_SCSI) += scsi_mod.o
obj-$(CONFIG_SCSI_TGT) += scsi_tgt.o
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] SCSI: make pcmcia directory use obj-y|m instead of subdir-y|m
2007-12-07 13:36 [PATCH] SCSI: make pcmcia directory use obj-y|m instead of subdir-y|m Tejun Heo
@ 2007-12-07 16:06 ` Sam Ravnborg
2007-12-07 22:35 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2007-12-07 16:06 UTC (permalink / raw)
To: Tejun Heo; +Cc: Linux Kernel, linux-scsi, James Bottomley
On Fri, Dec 07, 2007 at 10:36:23PM +0900, Tejun Heo wrote:
> subdir-y|m isn't supposed to contain modules or built-in components.
> Change subdir-$(CONFIG_PCMCIA) to obj-$(CONFIG_PCMCIA).
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: James Bottomley <James.Bottomley@SteelEye.com>
Ack-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/scsi/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
> index 2e6129f..72c8d2e 100644
> --- a/drivers/scsi/Makefile
> +++ b/drivers/scsi/Makefile
> @@ -18,7 +18,7 @@ CFLAGS_aha152x.o = -DAHA152X_STAT -DAUTOCONF
> CFLAGS_gdth.o = # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS
> CFLAGS_seagate.o = -DARBITRATE -DPARITY -DSEAGATE_USE_ASM
>
> -subdir-$(CONFIG_PCMCIA) += pcmcia
> +obj-$(CONFIG_PCMCIA) += pcmcia/
>
> obj-$(CONFIG_SCSI) += scsi_mod.o
> obj-$(CONFIG_SCSI_TGT) += scsi_tgt.o
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SCSI: make pcmcia directory use obj-y|m instead of subdir-y|m
2007-12-07 16:06 ` Sam Ravnborg
@ 2007-12-07 22:35 ` Tejun Heo
0 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2007-12-07 22:35 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Linux Kernel, linux-scsi, James Bottomley
Sam Ravnborg wrote:
> On Fri, Dec 07, 2007 at 10:36:23PM +0900, Tejun Heo wrote:
>> subdir-y|m isn't supposed to contain modules or built-in components.
>> Change subdir-$(CONFIG_PCMCIA) to obj-$(CONFIG_PCMCIA).
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Cc: James Bottomley <James.Bottomley@SteelEye.com>
> Ack-by: Sam Ravnborg <sam@ravnborg.org>
Thanks. I guess this should go through SCSI tree. James, can you
please forward this upstream?
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-07 22:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-07 13:36 [PATCH] SCSI: make pcmcia directory use obj-y|m instead of subdir-y|m Tejun Heo
2007-12-07 16:06 ` Sam Ravnborg
2007-12-07 22:35 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox