From: "Gregory Haskins" <ghaskins@novell.com>
To: <mingo@elte.hu>, <dmitry.adamushko@gmail.com>,
<rostedt@goodmis.org>, "Gregory Haskins" <GHaskins@novell.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] sched: Fixed missed rt-balance points on priority shifts
Date: Sun, 09 Dec 2007 22:18:31 -0500 [thread overview]
Message-ID: <475C69B7.BA47.005A.0@novell.com> (raw)
In-Reply-To: <20071210024709.4760.68134.stgit@novell1.haskins.net>
>>> On Sun, Dec 9, 2007 at 9:53 PM, in message
<20071210024709.4760.68134.stgit@novell1.haskins.net>, Gregory Haskins
<ghaskins@novell.com> wrote:
> + * I have no doubt that this is the proper thing to do to make
> + * sure RT tasks are properly balanced. What I cannot wrap my
> + * head around at this late hour is if issuing a reschedule()
> + * here may cause issues in other circumstances. TBD
> + */
> + if (!task_running(rq, p))
> + resched_task(rq->curr);
> + }
It dawned on me after I sent this that a further optimization here is to predicate the reschedule on whether we are overloaded. In otherwords:
if (!task_running(rq, p) && rt_overloaded(rq))
Regards,
-Greg
prev parent reply other threads:[~2007-12-10 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071130145939.GN5681@linux.vnet.ibm.com>
[not found] ` <b647ffbd0712011156p252ae29dnfa75494e4d2c845c@mail.gmail.com>
[not found] ` <20071203182223.GA4133@linux.vnet.ibm.com>
[not found] ` <47556B23.2060909@redhat.com>
[not found] ` <20071204153542.GC3388@linux.vnet.ibm.com>
[not found] ` <b647ffbd0712040828l51a26a82jc0f38d3f4aa2291e@mail.gmail.com>
[not found] ` <20071205134036.GA21933@linux.vnet.ibm.com>
[not found] ` <4756B8E9.3080709@redhat.com>
[not found] ` <20071205164800.GA24767@linux.vnet.ibm.com>
[not found] ` <4756D709.1020901@redhat.com>
2007-12-09 17:16 ` RT Load balance changes in sched-devel Dmitry Adamushko
2007-12-09 18:32 ` Gregory Haskins
2007-12-10 0:57 ` Steven Rostedt
2007-12-10 2:53 ` [PATCH RFC] sched: Fixed missed rt-balance points on priority shifts Gregory Haskins
2007-12-10 3:18 ` Gregory Haskins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475C69B7.BA47.005A.0@novell.com \
--to=ghaskins@novell.com \
--cc=dmitry.adamushko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox