From: HighPoint Linux Team <linux@highpoint-tech.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
James.Bottomley@SteelEye.com
Subject: Re: [PATCH][SCSI] hptiop: add more adapter models and other fixes
Date: Tue, 11 Dec 2007 11:07:37 +0800 [thread overview]
Message-ID: <475DFEF9.6060006@highpoint-tech.com> (raw)
In-Reply-To: <20071210165030.GB26334@parisc-linux.org>
Matthew Wilcox wrote:
>> - add more PCI device IDs
>> - support for adapters based on Marvell IOP
>
> Are you sure it's a good idea to do this? This patch is 1200 lines long
> ... the same size as the existing driver:
>
> $ wc drivers/scsi/hptiop.*
> 947 2273 24531 drivers/scsi/hptiop.c
> 256 612 6175 drivers/scsi/hptiop.h
> 1203 2885 30706 total
>
> That suggests to me there's not much commonality between the two drivers,
> and you'd be better off adding a second driver for the 4xxx cards
The new adapter implementation adds to the driver about 300 lines of
code (some lines in the original driver was changed slightly to accommodate
the difference). It is only different from the original models on the
messaging interface, and still shares same firmware command block
structures and work flow.
HighPoint Linux Team
prev parent reply other threads:[~2007-12-11 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 5:54 [PATCH][SCSI] hptiop: add more adapter models and other fixes HighPoint Linux Team
2007-12-10 16:50 ` Matthew Wilcox
2007-12-11 3:07 ` HighPoint Linux Team [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475DFEF9.6060006@highpoint-tech.com \
--to=linux@highpoint-tech.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox