From: Anthony Liguori <anthony@codemonkey.ws>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: 7eggert@gmx.de, Andrew Morton <akpm@linux-foundation.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: relax signature check
Date: Wed, 12 Dec 2007 13:14:58 -0600 [thread overview]
Message-ID: <47603332.8060605@codemonkey.ws> (raw)
In-Reply-To: <475EC5E5.80104@goop.org>
Jeremy Fitzhardinge wrote:
> Bodo Eggert wrote:
>> Not BUG_ON(memcmp(xen_start_info->magic, "xen-3.", 6) != 0); ?
>> I don't thin Xen version 32 will be compatible ...
>>
>
> It had better be; if it loads the kernel, it should present a xen-3
> compatible ABI.
If xen-32.0 should be compatible than wouldn't xen-24.0 be compatible
too? I think the point was that you should either be checking for
'xen-3.x' or something more general that would accept anything >= xen-3.0.
Regards,
Anthony Liguori
> But this is just a sanity check to make sure things are basically OK;
> BUG_ON is hardly nice error reporting (not that there's much else we can
> do at that point).
>
> J
next prev parent reply other threads:[~2007-12-12 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9yY38-5oa-11@gated-at.bofh.it>
2007-12-11 15:52 ` [PATCH] xen: relax signature check Bodo Eggert
2007-12-11 17:16 ` Jeremy Fitzhardinge
2007-12-12 19:14 ` Anthony Liguori [this message]
2007-12-12 19:36 ` Jeremy Fitzhardinge
2007-12-10 21:00 Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47603332.8060605@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=7eggert@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox