* scsi/lpfc/lpfc_attr.c: bogus code
@ 2007-12-11 22:20 Adrian Bunk
2007-12-12 22:00 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-12-11 22:20 UTC (permalink / raw)
To: James Smart, James Bottomley; +Cc: linux-scsi, linux-kernel
Commit 2e0fef85e098f6794956b8b80b111179fbb4cbb7 added the folowing code
to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be
dead code:
<-- snip -->
...
lpfc_state_show(struct class_device *cdev, char *buf)
{
...
switch (vport->port_state) {
len += snprintf(buf + len, PAGE_SIZE-len,
"initializing\n");
break;
...
<-- snip -->
Spotted by the GNU C compiler version 3.3.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: scsi/lpfc/lpfc_attr.c: bogus code
2007-12-11 22:20 scsi/lpfc/lpfc_attr.c: bogus code Adrian Bunk
@ 2007-12-12 22:00 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2007-12-12 22:00 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James Bottomley, linux-scsi, linux-kernel
This has already been fixed. It's in our 8.2.3 patches, which were merged into
James's scsi-misc-2.6 tree at the beginning of November, and targeted for 2.6.25.
-- james s
Adrian Bunk wrote:
> Commit 2e0fef85e098f6794956b8b80b111179fbb4cbb7 added the folowing code
> to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be
> dead code:
>
> <-- snip -->
>
> ...
> lpfc_state_show(struct class_device *cdev, char *buf)
> {
> ...
> switch (vport->port_state) {
> len += snprintf(buf + len, PAGE_SIZE-len,
> "initializing\n");
> break;
> ...
>
> <-- snip -->
>
> Spotted by the GNU C compiler version 3.3.
>
> cu
> Adrian
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-12 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-11 22:20 scsi/lpfc/lpfc_attr.c: bogus code Adrian Bunk
2007-12-12 22:00 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox