From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755949AbXLLXZ3 (ORCPT ); Wed, 12 Dec 2007 18:25:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751397AbXLLXZW (ORCPT ); Wed, 12 Dec 2007 18:25:22 -0500 Received: from terminus.zytor.com ([198.137.202.10]:43811 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbXLLXZV (ORCPT ); Wed, 12 Dec 2007 18:25:21 -0500 Message-ID: <47606DC3.2010905@zytor.com> Date: Wed, 12 Dec 2007 15:24:51 -0800 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Jeremy Fitzhardinge CC: Harvey Harrison , Ingo Molnar , Thomas Gleixner , LKML Subject: Re: [PATCH] x86: Remove 'e' from kprope structure members References: <1197421087.8761.27.camel@brick> <47602776.10408@zytor.com> <1197487642.21291.1.camel@brick> <47606804.1010709@goop.org> <47606A00.2080108@zytor.com> <47606CD5.6050403@goop.org> In-Reply-To: <47606CD5.6050403@goop.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeremy Fitzhardinge wrote: > H. Peter Anvin wrote: >> Jeremy Fitzhardinge wrote: >>> Harvey Harrison wrote: >>>> Some kprobe structure members had a superfluous e in their >>>> name. >>>> >>>> eflags -> flags >>>> esp -> sp >>>> >>> eflags and esp are the actual machine register names (at least in >>> 32-bit), and therefore more distinctive than just "flags". >>> If this is in preparation for a unification then OK, but I disagree if >>> not (and technically 64-bit should be using rsp/rflags). >>> >> Yes, that's the whole point (unification.) > > OK, great. I was just confused because the patch changelog didn't give > a proper rationale for the change (the 'e' isn't superfluous, and > removing it isn't a goal in itself). > True, it probably should say it's a precursor to unification. -hpa