public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [x86_64] remove unused variable from drivers/ata/ahci.c
@ 2007-12-15  0:11 Michael Kühn
  2007-12-15  2:41 ` Mark Lord
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Kühn @ 2007-12-15  0:11 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

Hi,

my first kernel patch, yay. :-)

On the file drivers/ata/ahci.c in line 1433 is declared a variable that
is never used in the function. I removed it.

Patch is in attachments (based on 2.6.23.10).

[-- Attachment #2: ahci.patch --]
[-- Type: text/x-patch, Size: 355 bytes --]

--- linux-2.6.23.10/drivers/ata/ahci.c	2007-12-14 19:01:59.000000000 +0100
+++ linux-2.6.23.10.new/drivers/ata/ahci.c	2007-12-15 01:03:41.000000000 +0100
@@ -1430,7 +1430,6 @@
 {
 	void __iomem *port_mmio = ap->ioaddr.cmd_addr;
 	struct ata_eh_info *ehi = &ap->eh_info;
-	struct ahci_port_priv *pp = ap->private_data;
 	u32 status, qc_active;
 	int rc;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [x86_64] remove unused variable from drivers/ata/ahci.c
  2007-12-15  0:11 [x86_64] remove unused variable from drivers/ata/ahci.c Michael Kühn
@ 2007-12-15  2:41 ` Mark Lord
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Lord @ 2007-12-15  2:41 UTC (permalink / raw)
  To: Michael Kühn; +Cc: linux-kernel

Michael Kühn wrote:
> Hi,
> 
> my first kernel patch, yay. :-)
> 
> On the file drivers/ata/ahci.c in line 1433 is declared a variable that
> is never used in the function. I removed it.
> 
> Patch is in attachments (based on 2.6.23.10).

...

You'll need to do:

(1) repost it, but this time to linux-ide@vger.kernel.org,
(2) place the patch INLINE, where it's easier to comment/correct as needed,
(3) include a Signed-off-by line,
(4) read / follow much of the Documentation/SubmittingPatches file.

*Then* you can try for fame and glory!

:)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-12-15  2:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-15  0:11 [x86_64] remove unused variable from drivers/ata/ahci.c Michael Kühn
2007-12-15  2:41 ` Mark Lord

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox