From: "H. Peter Anvin" <hpa@zytor.com>
To: devzero@web.de
Cc: linux-kernel@vger.kernel.org, Matt.Domsch@dell.com
Subject: Re: [PATCH] [RFC] be more verbose when probing EDD
Date: Sun, 16 Dec 2007 10:17:02 -0800 [thread overview]
Message-ID: <47656B9E.3040405@zytor.com> (raw)
In-Reply-To: <49015158@web.de>
devzero@web.de wrote:
> /* Query EDD information */
> #if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)
> - query_edd();
> + printf("Probing EDD (query Bios for boot-device information)\n");
> + printf("If boot hangs here, you may have a buggy Bios. Try edd=skipmbr or edd=off");
> + query_edd();
> + printf("\rOK \n");
> #endif
This is awfully verbose.
I'd prefer something like:
printf("Probing EDD BIOS... ");
query_edd();
printf("ok\n");
[or even "failed"...]
Also, you really should look for the "quiet" command-line option and
squelch the message.
-hpa
next prev parent reply other threads:[~2007-12-16 18:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 15:34 [PATCH] [RFC] be more verbose when probing EDD devzero
2007-12-16 17:34 ` Parag Warudkar
2007-12-16 18:17 ` H. Peter Anvin [this message]
2007-12-22 1:15 ` Andi Kleen
2007-12-22 1:48 ` H. Peter Anvin
2007-12-22 1:57 ` Andi Kleen
2007-12-22 2:22 ` H. Peter Anvin
2007-12-22 2:41 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2007-12-16 19:11 devzero
2007-12-16 19:59 ` Parag Warudkar
2007-12-16 20:18 ` Alan Cox
2007-12-17 23:25 ` Jan Engelhardt
2007-12-17 23:27 ` H. Peter Anvin
2007-12-18 0:10 ` Alan Cox
2007-12-18 0:22 ` H. Peter Anvin
2007-12-16 19:19 devzero
2007-12-16 21:04 devzero
2007-12-16 21:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47656B9E.3040405@zytor.com \
--to=hpa@zytor.com \
--cc=Matt.Domsch@dell.com \
--cc=devzero@web.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox