Re: Final kprobes rollup patches

[Masami Hiramatsu <mhiramat@redhat.com>]

Hi Ingo,

Ingo Molnar wrote:
> Masami,
> 
> * Masami Hiramatsu <mhiramat@redhat.com> wrote:
> 
>> Hi Harvey and Ingo,
>>
>> I'm working on another version of patches for unification.
>> Currently cleaning up the patches.
>> http://sources.redhat.com/ml/systemtap/2007-q4/msg00457.html
>> I'll cleanup and repost it today.
> 
> cool! Please Cc: lkml and Harvey as well so that there's less overlap in 
> unification work - Harvey spent quite some time unifying and cleaning up 
> the kprobes code during the past week.

Should I rewrite it based on current git tree?
My patch includes 3 part of patches.
- 2 Bugfix patches (which is not merged yet.)
- 2 booster patches (ditto)
- 2 unification patches (most of this patches are already done by Harvey's patch)

> 
> So i think we could/should use Harvey's latest series as a base, those 
> are pretty finegrained already. Note that they break 64-bit kprobes 
> though, with such a config:
> 
>  CONFIG_KPROBES=y
>  CONFIG_NET_TCPPROBE=y
> 
> so it crashes with an int3 in the TCP code. It's probably some trivial 
> typo somewhere, as 32-bit works fine.
> 
> the coordinates for x86.git#mm can be found below - that tree already 
> includes Harvey's latest kprobes series. I'll try to bisect the 64-bit 
> breakage now.
> 
> 	Ingo
> 
> ------------------>
>  git-clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6.git
>  cd linux-2.6.git
>  git-branch x86
>  git-checkout x86
>  git-pull git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git mm
> 
> (do subsequent pulls via "git-pull --force", as we frequently rebase the
> git tree. NOTE: this might override your own local changes, so do this
> only if you dont mind about losing thse changes in that tree.)
> 

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com