From: Roel Kluin <12o3l@tiscali.nl>
To: mac@melware.de
Cc: isdn4linux@listserv.isdn4linux.de, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH drivers/isdn/hardware/eicon/message.c] fix 'and' typo in eicons' AddInfo()
Date: Mon, 17 Dec 2007 17:05:28 +0100 [thread overview]
Message-ID: <47669E48.4030109@tiscali.nl> (raw)
I have previously sent this to isdn4linux@listserv.isdn4linux.de and its
maintainer, but the error is still in linus' tree.
--
'!' has a higher priority than '&', so as was the bit test masks a binary.
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c
index ccd35d0..189b231 100644
--- a/drivers/isdn/hardware/eicon/message.c
+++ b/drivers/isdn/hardware/eicon/message.c
@@ -9027,7 +9027,7 @@ static byte AddInfo(byte **add_i,
/* facility is a nested structure */
/* FTY can be more than once */
- if(esc_chi[0] && !(esc_chi[esc_chi[0]])&0x7f )
+ if (esc_chi[0] && !(esc_chi[esc_chi[0]] & 0x7f))
{
add_i[0] = (byte *)"\x02\x02\x00"; /* use neither b nor d channel */
}
reply other threads:[~2007-12-17 16:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47669E48.4030109@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox