From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdBUA2W (ORCPT ); Mon, 20 Feb 2017 19:28:22 -0500 Received: from mga06.intel.com ([134.134.136.31]:58753 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbdBUA2V (ORCPT ); Mon, 20 Feb 2017 19:28:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,187,1484035200"; d="scan'208";a="50502068" Subject: Re: [PATCH v3 0/5] perf report: Show inline stack To: acme@kernel.org, jolsa@kernel.org References: <1484905166-10609-1-git-send-email-yao.jin@linux.intel.com> Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, milian.wolff@kdab.com From: "Jin, Yao" Message-ID: <47669ba5-6f26-2842-e274-949411c5cb36@linux.intel.com> Date: Tue, 21 Feb 2017 08:28:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1484905166-10609-1-git-send-email-yao.jin@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Any comments for this patch series? Thanks Jin Yao On 1/20/2017 5:39 PM, Jin Yao wrote: > v3: Iterate on RIPs of all callchain entries to check if the RIP is in > inline functions. > > Reverse the order of the inliner printout if necessary. > > Provide new options "--inline-line" / "--inline-name" to print > inline function name or print inline function source line. > > v2: Thanks so much for Arnaldo's comments! > The modifications are: > > 1. Divide v1 patch "perf report: Find the inline stack for a > given address" into 2 patches: > a. perf report: Refactor common code in srcline.c > b. perf report: Find the inline stack for a given address > > Some function names are changed: > dso_name_get -> dso__name > ilist_apend -> inline_list__append > get_inline_node -> dso__parse_addr_inlines > free_inline_node -> inline_node__delete > > 2. Since the function name are changed, update following patches > accordingly. > a. perf report: Show inline stack in stdio mode > b. perf report: Show inline stack in browser mode > > 3. Rebase to latest perf/core branch. This patch is impacted. > a. perf report: Create a new option "--inline" > > v1: Initial post > > It would be useful for perf to support a mode to query the > inline stack for callgraph addresses. This would simplify > finding the right code in code that does a lot of inlining. > > For example, the c code: > > static inline void f3(void) > { > int i; > for (i = 0; i < 1000;) { > > if(i%2) > i++; > else > i++; > } > printf("hello f3\n"); /* D */ > } > > /* < CALLCHAIN: f2 <- f1 > */ > static inline void f2(void) > { > int i; > for (i = 0; i < 100; i++) { > f3(); /* C */ > } > } > > /* < CALLCHAIN: f1 <- main > */ > static inline void f1(void) > { > int i; > for (i = 0; i < 100; i++) { > f2(); /* B */ > } > } > > /* < CALLCHAIN: main <- TOP > */ > int main() > { > struct timeval tv; > time_t start, end; > > gettimeofday(&tv, NULL); > start = end = tv.tv_sec; > while((end - start) < 5) { > f1(); /* A */ > gettimeofday(&tv, NULL); > end = tv.tv_sec; > } > return 0; > } > > The printed inline stack is: > > 0.05% test2 test2 [.] main > | > ---/home/perf-dev/lck-2867/test/test2.c:27 (inline) > /home/perf-dev/lck-2867/test/test2.c:35 (inline) > /home/perf-dev/lck-2867/test/test2.c:45 (inline) > /home/perf-dev/lck-2867/test/test2.c:61 (inline) > > I tag A/B/C/D in above c code to indicate the source line, > actually the inline stack is equal to: > > 0.05% test2 test2 [.] main > | > ---D > C > B > A > > Jin Yao (5): > perf report: Refactor common code in srcline.c > perf report: Find the inline stack for a given address > perf report: Create new inline options > perf report: Show inline stack in stdio mode > perf report: Show inline stack in browser mode > > tools/perf/Documentation/perf-report.txt | 8 ++ > tools/perf/builtin-report.c | 4 + > tools/perf/ui/browsers/hists.c | 170 ++++++++++++++++++++-- > tools/perf/ui/stdio/hist.c | 75 +++++++++- > tools/perf/util/hist.c | 5 + > tools/perf/util/sort.h | 1 + > tools/perf/util/srcline.c | 237 +++++++++++++++++++++++++++---- > tools/perf/util/symbol-elf.c | 5 + > tools/perf/util/symbol.h | 6 +- > tools/perf/util/util.h | 16 +++ > 10 files changed, 489 insertions(+), 38 deletions(-) >