public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Tony Luck <tony.luck@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	protasnb@gmail.com, tytso@thunk.org
Subject: Re: Top kernel oopses/warnings this week
Date: Mon, 17 Dec 2007 15:17:56 -0800	[thread overview]
Message-ID: <476703A4.7000401@linux.intel.com> (raw)
In-Reply-To: <12c511ca0712171458n1bc05b40nab6b4b7c92433c8d@mail.gmail.com>

Tony Luck wrote:
>> +       static char target[80];
>  ...
>> +               sprintf(target, "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-"
>> +                       "%02x%02x%02x%02x%02x%02x",
> 
> [80] is overkill ... [37] bytes should be enough (unless I went
> cross-eyed counting the "%02x" :-)
> 

%02x doesn't guarantee that it's at most 2, but at LEAST 2...

  reply	other threads:[~2007-12-17 23:22 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14 18:46 Top kernel oopses/warnings this week Arjan van de Ven
2007-12-14 18:58 ` Dave Jones
2007-12-14 21:57 ` Andrew Morton
2007-12-14 22:25   ` Natalie Protasevich
2007-12-15  0:38   ` Arjan van de Ven
2007-12-14 22:12 ` Jon Masters
2007-12-15 15:49 ` Stefan Richter
2007-12-15 18:21   ` Arjan van de Ven
2007-12-15 19:44     ` Stefan Richter
2007-12-17 18:25     ` Zach Brown
2007-12-17 18:41       ` Arjan van de Ven
2007-12-17  2:51   ` Dave Jones
2007-12-17 12:33     ` Jon Masters
2007-12-17 13:13       ` Stefan Richter
2007-12-17 16:40         ` Arjan van de Ven
2007-12-17 17:23 ` Ingo Molnar
2007-12-17 21:36   ` Arjan van de Ven
2007-12-17 21:58     ` Theodore Tso
2007-12-17 22:58     ` Tony Luck
2007-12-17 23:17       ` Arjan van de Ven [this message]
2007-12-17 23:26         ` Tony Luck
2007-12-17 23:47           ` Arjan van de Ven
2007-12-18  0:21             ` Linus Torvalds
2007-12-18  0:39               ` Arjan van de Ven
2007-12-18  2:31               ` Theodore Tso
2007-12-18  6:58                 ` Arjan van de Ven
2007-12-18 17:53                   ` Matt Mackall
2007-12-18 18:28                   ` Theodore Tso
2007-12-18 18:45                     ` Linus Torvalds
2007-12-18 10:11                 ` Jon Masters
2007-12-18 18:06               ` Arjan van de Ven
2007-12-18 18:13                 ` Matt Mackall
2007-12-18 18:19                   ` Arjan van de Ven
2007-12-18 17:48     ` Matt Mackall
2007-12-18 23:37       ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476703A4.7000401@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=protasnb@gmail.com \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@thunk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox