From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S936622AbXLQXTw@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S936622AbXLQXTw (ORCPT <rfc822;w@1wt.eu>);
	Mon, 17 Dec 2007 18:19:52 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932312AbXLQXTm
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 17 Dec 2007 18:19:42 -0500
Received: from srv5.dvmed.net ([207.36.208.214]:48960 "EHLO mail.dvmed.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1761981AbXLQXTl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 17 Dec 2007 18:19:41 -0500
Message-ID: <47670409.7040803@garzik.org>
Date: Mon, 17 Dec 2007 18:19:37 -0500
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Andrew Gallatin <gallatin@myri.com>
CC: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()
References: <47602AAA.8060204@myri.com>
In-Reply-To: <47602AAA.8060204@myri.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -4.4 (----)
X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary:
	Content analysis details:   (-4.4 points, 5.0 required)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andrew Gallatin wrote:
> Remove the bogus netif_running() check from myri10ge_poll().
> 
> This eliminates any chance that myri10ge_poll() can trigger
> an oops by calling netif_rx_complete() and returning
> with work_done == budget.
> 
> Signed-off-by: Andrew Gallatin <gallatin@myri.com>

holding onto this patch but not applying, because NAPI discussions 
appear to be continuing...