From: "H. Peter Anvin" <hpa@zytor.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
Parag Warudkar <parag.warudkar@gmail.com>,
devzero@web.de, Matt.Domsch@dell.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] be more verbose when probing EDD
Date: Mon, 17 Dec 2007 16:22:21 -0800 [thread overview]
Message-ID: <476712BD.4020008@zytor.com> (raw)
In-Reply-To: <20071218001007.2324dbfc@the-village.bc.nu>
Alan Cox wrote:
>> Does printk support escape sequences? The last time I tried
>> printk("\e[1;35m omg ponies \e[0m"); that did not went too successful.
>
> It should handle \r correctly. If not that is easy to fix.
>
> Escape codes are bad and should not be used - you may have a serial
> console and not be on a Linux console
It's not printk(), or the console, that's the issue...
Consider logging to a file, which is quite common.
Dumping formatting characters in there is a bit evil.
Instead of using \r and overwrite, something like
Testing foo... ok
printk(KERN_INFO "Testing foo... ");
foo();
printk("ok\n");
... really is a lot better. We used to do that a lot more.
-hpa
next prev parent reply other threads:[~2007-12-18 0:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 19:11 [PATCH] [RFC] be more verbose when probing EDD devzero
2007-12-16 19:59 ` Parag Warudkar
2007-12-16 20:18 ` Alan Cox
2007-12-17 23:25 ` Jan Engelhardt
2007-12-17 23:27 ` H. Peter Anvin
2007-12-18 0:10 ` Alan Cox
2007-12-18 0:22 ` H. Peter Anvin [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-16 21:04 devzero
2007-12-16 21:01 ` Alan Cox
2007-12-16 19:19 devzero
2007-12-16 15:34 devzero
2007-12-16 17:34 ` Parag Warudkar
2007-12-16 18:17 ` H. Peter Anvin
2007-12-22 1:15 ` Andi Kleen
2007-12-22 1:48 ` H. Peter Anvin
2007-12-22 1:57 ` Andi Kleen
2007-12-22 2:22 ` H. Peter Anvin
2007-12-22 2:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476712BD.4020008@zytor.com \
--to=hpa@zytor.com \
--cc=Matt.Domsch@dell.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=devzero@web.de \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=parag.warudkar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox