From: Masami Hiramatsu <mhiramat@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@us.ibm.com>,
Roland McGrath <roland@redhat.com>,
prasanna@in.ibm.com, anil.s.keshavamurthy@intel.com,
davem@davemloft.net, Harvey Harrison <harvey.harrison@gmail.com>,
systemtap-ml <systemtap@sources.redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption
Date: Wed, 19 Dec 2007 11:03:28 -0500 [thread overview]
Message-ID: <476940D0.30106@redhat.com> (raw)
In-Reply-To: <20071219102007.GE3521@elte.hu>
Hi Ingo,
Ingo Molnar wrote:
> * Masami Hiramatsu <mhiramat@redhat.com> wrote:
>
>>> - return 1;
>>> + ret = 1;
>> Here, "return 1;" is correct. After single step is done, preemption is
>> enabled in post_kprobe_handler().
>
> could you resend the fixed patch? (instead of me fixing it up by hand -
> which is error-prone)
Sure, I'll resend asap.
>
> also, this seems like .24 material as well - could you send the fix
> against -rc5 too?
-rc tree is fine. Actually, it was introduced by my cleanup patch.
Thanks!
>
> Ingo
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com
prev parent reply other threads:[~2007-12-19 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 23:18 [PATCH 1/2] x86: fix kprobe_handler reenable preemption Masami Hiramatsu
2007-12-19 3:32 ` Masami Hiramatsu
2007-12-19 10:20 ` Ingo Molnar
2007-12-19 16:03 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476940D0.30106@redhat.com \
--to=mhiramat@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasanna@in.ibm.com \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).