* [PATCH 1/3] x86: fix kprobe_handler reenable preemption
@ 2007-12-19 21:48 Masami Hiramatsu
2007-12-20 9:15 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu @ 2007-12-19 21:48 UTC (permalink / raw)
To: Ananth N Mavinakayanahalli, Jim Keniston, Ingo Molnar
Cc: Roland McGrath, prasanna, anil.s.keshavamurthy, davem,
Harvey Harrison, systemtap-ml, LKML, Arjan van de Ven
Fix a preemption bug in kprobe_handler(). It has to call preempt_enable()
before returning.
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
---
arch/x86/kernel/kprobes.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: b/arch/x86/kernel/kprobes.c
===================================================================
--- a/arch/x86/kernel/kprobes.c
+++ b/arch/x86/kernel/kprobes.c
@@ -467,7 +467,8 @@ static int __kprobes kprobe_handler(stru
arch_disarm_kprobe(p);
regs->ip = (unsigned long)p->addr;
reset_current_kprobe();
- return 1;
+ ret = 1;
+ goto no_kprobe;
#endif
}
/* We have reentered the kprobe_handler(), since
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] x86: fix kprobe_handler reenable preemption
2007-12-19 21:48 [PATCH 1/3] x86: fix kprobe_handler reenable preemption Masami Hiramatsu
@ 2007-12-20 9:15 ` Ingo Molnar
2007-12-20 10:22 ` Jaswinder Singh
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2007-12-20 9:15 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: Ananth N Mavinakayanahalli, Jim Keniston, Roland McGrath,
prasanna, anil.s.keshavamurthy, davem, Harvey Harrison,
systemtap-ml, LKML, Arjan van de Ven
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Fix a preemption bug in kprobe_handler(). It has to call
> preempt_enable() before returning.
thanks - i've applied all 3 kprobes patches from you. (for v2.6.25)
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] x86: fix kprobe_handler reenable preemption
2007-12-20 9:15 ` Ingo Molnar
@ 2007-12-20 10:22 ` Jaswinder Singh
2007-12-20 10:33 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Jaswinder Singh @ 2007-12-20 10:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: Masami Hiramatsu, Ananth N Mavinakayanahalli, Jim Keniston,
Roland McGrath, prasanna, anil.s.keshavamurthy, davem,
Harvey Harrison, systemtap-ml, LKML, Arjan van de Ven
v2.6.25 or v2.6.24 ?
On Dec 20, 2007 2:45 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Masami Hiramatsu <mhiramat@redhat.com> wrote:
>
> > Fix a preemption bug in kprobe_handler(). It has to call
> > preempt_enable() before returning.
>
> thanks - i've applied all 3 kprobes patches from you. (for v2.6.25)
>
> Ingo
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] x86: fix kprobe_handler reenable preemption
2007-12-20 10:22 ` Jaswinder Singh
@ 2007-12-20 10:33 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2007-12-20 10:33 UTC (permalink / raw)
To: Jaswinder Singh
Cc: Masami Hiramatsu, Ananth N Mavinakayanahalli, Jim Keniston,
Roland McGrath, prasanna, anil.s.keshavamurthy, davem,
Harvey Harrison, systemtap-ml, LKML, Arjan van de Ven
* Jaswinder Singh <jaswinderlinux@gmail.com> wrote:
> v2.6.25 or v2.6.24 ?
see: http://www.zip.com.au/~akpm/linux/patches/stuff/top-posting.txt
> On Dec 20, 2007 2:45 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Masami Hiramatsu <mhiramat@redhat.com> wrote:
> >
> > > Fix a preemption bug in kprobe_handler(). It has to call
> > > preempt_enable() before returning.
> >
> > thanks - i've applied all 3 kprobes patches from you. (for v2.6.25)
/^^^^^^^^^^^^
also see: ---------------------------------------------/
(this bug is not present in .24)
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-20 10:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-19 21:48 [PATCH 1/3] x86: fix kprobe_handler reenable preemption Masami Hiramatsu
2007-12-20 9:15 ` Ingo Molnar
2007-12-20 10:22 ` Jaswinder Singh
2007-12-20 10:33 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).