From: Tony Camuso <tcamuso@redhat.com>
To: gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [Fwd: Re: [PATCH 1/5]PCI: x86 MMCONFIG: introduce PCI_USING_MMCONF]
Date: Thu, 20 Dec 2007 09:19:00 -0500 [thread overview]
Message-ID: <476A79D4.4090002@redhat.com> (raw)
In-Reply-To: <476A5EAF.6020008@redhat.com>
Tony Camuso wrote:
>
> Greg KH wrote:
>> On Wed, Dec 19, 2007 at 05:17:51PM -0500, tcamuso@redhat.com wrote:
>>>
>>> +extern struct pci_ops pci_legacy_ops; /* direct.c */
>>
>> This isn't needed in this patch at all, and might make the compiler
>> confused if you were to build with only this patch present :(
>>
>> thanks,
>>
>> greg k-h
>
> Yes, of course. I missed that. Thank you.
>
I take that back.
This struct must be declared extern because it is referenced in
arch/x86/pci/common.c by pcibios_fix_bus_scan_quirk()
next prev parent reply other threads:[~2007-12-20 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 12:23 [Fwd: Re: [PATCH 1/5]PCI: x86 MMCONFIG: introduce PCI_USING_MMCONF] Tony Camuso
2007-12-20 14:19 ` Tony Camuso [this message]
2007-12-20 16:48 ` Greg KH
2007-12-20 17:00 ` Tony Camuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476A79D4.4090002@redhat.com \
--to=tcamuso@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox