From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <Yinghai.Lu@Sun.COM>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: not needed patch
Date: Thu, 20 Dec 2007 06:56:15 -0800 [thread overview]
Message-ID: <476A828F.2010706@sgi.com> (raw)
In-Reply-To: <20071220142906.GA20794@elte.hu>
Ingo Molnar wrote:
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
>> Ingo.
>>
>> commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9 is not needed. another
>> patch (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669 x86:
>> fixup cpu_info array conversion) already removed clearing of
>> c->cpu_index. in identify_cpu
>> also it is not consisent to smpboot_32.c. (it will assign id to
>> cpu_index right after
>>
>> *c = boot_cpu_data;
>> )
>
> well, it might in the worst-case be a superfluous change, but not cause
> any problems in 2.6.24, right?
>
>> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
>> use c->cpu_index in identify_cpu.
>
> but that's 2.6.25 stuff, right? Travis?
Since 6.5.24 needs to close soon, I'll queue up this change for 6.5.25.
Thanks everyone!
-Mike
next prev parent reply other threads:[~2007-12-20 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 4:57 not needed patch Yinghai Lu
2007-12-20 14:29 ` Ingo Molnar
2007-12-20 14:56 ` Mike Travis [this message]
2007-12-20 16:28 ` Mike Travis
2007-12-20 16:33 ` Ingo Molnar
2007-12-20 16:53 ` Mike Travis
2007-12-20 19:54 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476A828F.2010706@sgi.com \
--to=travis@sgi.com \
--cc=Yinghai.Lu@Sun.COM \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox