From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <Yinghai.Lu@Sun.COM>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: not needed patch
Date: Thu, 20 Dec 2007 08:53:59 -0800 [thread overview]
Message-ID: <476A9E27.8060302@sgi.com> (raw)
In-Reply-To: <20071220163352.GA6930@elte.hu>
Ingo Molnar wrote:
> * Mike Travis <travis@sgi.com> wrote:
>
>>>> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
>>>> use c->cpu_index in identify_cpu.
>>> but that's 2.6.25 stuff, right? Travis?
>>>
>> Looking at this more closely, yes my change is not needed and should
>> be removed. I'm not sure what caused my cpu # to be all zeros when I
>> was testing, but it now works ok without my change.
>
> how about this question:
>
>>> well, it might in the worst-case be a superfluous change, but not
>>> cause any problems in 2.6.24, right?
>
> Ingo
I don't think it hurts anything except as noted, it wouldn't be available
to the subfunctions (like identify_cpu) that might need the cpu_index
(which also is noted that none currently do.)
-Mike
next prev parent reply other threads:[~2007-12-20 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 4:57 not needed patch Yinghai Lu
2007-12-20 14:29 ` Ingo Molnar
2007-12-20 14:56 ` Mike Travis
2007-12-20 16:28 ` Mike Travis
2007-12-20 16:33 ` Ingo Molnar
2007-12-20 16:53 ` Mike Travis [this message]
2007-12-20 19:54 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476A9E27.8060302@sgi.com \
--to=travis@sgi.com \
--cc=Yinghai.Lu@Sun.COM \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox