From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765066AbXLUDFF (ORCPT ); Thu, 20 Dec 2007 22:05:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754130AbXLUDEz (ORCPT ); Thu, 20 Dec 2007 22:04:55 -0500 Received: from terminus.zytor.com ([198.137.202.10]:46631 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753161AbXLUDEy (ORCPT ); Thu, 20 Dec 2007 22:04:54 -0500 Message-ID: <476B2B5E.5060204@zytor.com> Date: Thu, 20 Dec 2007 18:56:30 -0800 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Mathieu Desnoyers CC: akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, Andi Kleen , Chuck Ebbert , Christoph Hellwig , Jeremy Fitzhardinge , Thomas Gleixner , Ingo Molnar , Rusty Russell Subject: Re: [patch 14/24] Immediate Values - x86 Optimization References: <20071221015438.433195466@polymtl.ca> <20071221015726.909058404@polymtl.ca> In-Reply-To: <20071221015726.909058404@polymtl.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch is modified by another patch in the sequence. This feels needlessly confusing when reviewing (especially since the comment doesn't look to match the code, e.g. w.r.t to "Q" and "R" constraints); can you reorder the patchset to avoid that? -hpa