From: "Jan Beulich" <jbeulich@novell.com>
To: "Dave Jones" <davej@redhat.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c
Date: Fri, 21 Dec 2007 07:41:23 +0000 [thread overview]
Message-ID: <476B7C33.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20071221023031.GA23320@redhat.com>
Thanks for catching this!
>>> Dave Jones <davej@redhat.com> 21.12.07 03:30 >>>
On Thu, Dec 20, 2007 at 04:14:05PM -0700, Eric W. Biederman wrote:
> Remains the question whether it is intended that many, perhaps even
> large, tables are compiled in without ever having a chance to get used,
> i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
> -static struct trans_ctl_table trans_net_ax25_param_table[] = {
> +static const struct trans_ctl_table trans_net_ax25_table[] = {
we lost the _param, which will cause a duplicate definition with ..
> -static struct trans_ctl_table trans_net_ax25_table[] = {
> +static const struct trans_ctl_table trans_net_ax25_table[] = {
cut-n-paste thinko ?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-12-21 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 23:14 [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c Eric W. Biederman
2007-12-21 2:30 ` Dave Jones
2007-12-21 7:41 ` Jan Beulich [this message]
2007-12-21 13:17 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476B7C33.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox