From: "Jan Beulich" <jbeulich@novell.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] constify tables in kernel/sysctl_check.c
Date: Fri, 21 Dec 2007 07:47:55 +0000 [thread overview]
Message-ID: <476B7DBB.76E4.0078.0@novell.com> (raw)
In-Reply-To: <m1y7bp6k7b.fsf@ebiederm.dsl.xmission.com>
>>> Eric W. Biederman <ebiederm@xmission.com> 21.12.07 00:05 >>>
>"Jan Beulich" <jbeulich@novell.com> writes:
>
>> Remains the question whether it is intended that many, perhaps even
>> large, tables are compiled in without ever having a chance to get used,
>> i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
>
>
>The constification looks good. The file should be compiled only when
>we have sysctl support. We use those tables when we call
>register_sysctl_table. Which we do a lot.
I understand this. Nevertheless, the tables take 23k on 64-bits, and many
of them are unused when certain subsystems aren't being built (and some
are even architecture specific). The arlan tables are a particularly good
example, but the netfilter ones are pretty big and probably not always
used, too.
Jan
next prev parent reply other threads:[~2007-12-21 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <476A73A3.76E4.0078.0@novell.com>
2007-12-20 23:05 ` [PATCH] constify tables in kernel/sysctl_check.c Eric W. Biederman
2007-12-21 7:47 ` Jan Beulich [this message]
2007-12-21 13:33 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476B7DBB.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox