From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757794AbXLUMlq (ORCPT ); Fri, 21 Dec 2007 07:41:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751046AbXLUMlh (ORCPT ); Fri, 21 Dec 2007 07:41:37 -0500 Received: from gateway-1237.mvista.com ([63.81.120.155]:30765 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750723AbXLUMlg (ORCPT ); Fri, 21 Dec 2007 07:41:36 -0500 Message-ID: <476BB495.5050809@ru.mvista.com> Date: Fri, 21 Dec 2007 15:41:57 +0300 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 20/63] ide-cd: remove needless zeroing of 'info' fields from ide_cdrom_setup() References: <200712200208.20568.bzolnier@gmail.com> In-Reply-To: <200712200208.20568.bzolnier@gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bartlomiej Zolnierkiewicz wrote: > ide_cd_probe() zeroes 'info' prior to calling ide_cdrom_setup() so there > is no need to explicitly zero 'info' fields in the latter function. > Ditto for fields of CDROM_STATE_FLAGS(), CDROM_CONFIG_FLAGS() and 'cdi' > (all are embedded in 'info'). > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sergei Shtylyov MBR, Sergei