Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

Greg KH
2007-12-22T19:23:17Z

On Sat, Dec 22, 2007 at 10:22:29AM -0600, Robert Hancock wrote:
> Arjan van de Ven wrote:
>> Hi,
>> Linus really wants the extended (4Kb) PCI configuration space (using MCFG
>> acpi table etc) to be opt-in, since there's many issues with it and most
>> drivers don't even use/need it. The idea behind opt-in is that if you
>> don't use it, you don't get to suffer the bugs...
>> Booted on my 64 bit test machine; sadly it has a defunct BIOS that doesn't
>> have a working MCFG.
>> From: Arjan van de Ven <arjan@linux.intel.com>
>> Subject: Make MMCONFIG space a driver opt-in
>> There are many issues with using the extended PCI configuration space
>> (CPU, Chipset and most of all BIOS bugs). This while the vast majority of
>> drivers
>> and devices don't even use/need to use the memory mapped access methods
>> since they
>> don't use the config space beyond the traditional 256 bytes.
>> This patch makes accessing the extended config space a driver choice, via
>> the
>> pci_enable_ext_config(pdev)
>> API function; drivers that want/need the extended configuration space
>> should call this.
>> (a separate patch will be posted to add this function call to the driver
>> that uses this)
>
> I don't really like this approach. Whether MMCONFIG works or not has
> nothing to do with the device itself, it's an attribute of the machine, and
> possibly the bus it's been plugged into. This patch might prevent problems
> in some cases, but it's equally likely to just delay problems until
> somebody plugs in a device that tries to use extended config space.

But it is that device, and the driver that controls this device that
cares about the extended config space. So it's fair to push this onto
the driver if needed, instead of forcing the pci core to just blindly
guess for all devices, and getting it wrong...

thanks,

greg k-h