Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

Linus Torvalds
2007-12-23T03:46:47Z

On Sat, 22 Dec 2007, Jeff Garzik wrote:
>
> I forcibly turn on mmconfig on all my machines, and monitor lkml, to make sure
> I'm aware of the extent of the problem -- and the extent of peoples'
> exaggeration of this problem.

Bullshit.

You have how many machines? Ten?

The problem is that it isn't enough that it works on common machines with
good hardware. The problem is that we end up chasing insane bugs, wasting
peoples valuable time and effort, on those *few* - out of *millions* - of
machines that then surprisingly don't work.

And "surprisingly" is definitely the watch-word. That includes silently
just not booting (because the first time anybody tries to do a PCI config
cycle access, the machine just locks up) to some really *odd* behaviour
(ie everything works fine *except* that reading the PCI card ID from a
few cards returns a value of 0x0001 rather than the correct one).

The fact is, we're currently turning off MMCONFIG very aggressively,
exactly because it has caused problems. So most people never even use
MMCONFIG when it's enabled, because all of our sanity checks that turn it
off again. And it still has caused odd problems.

> Regardless of whether a driver is loaded or not, you may NEED to see extended
> capabilities. The system may NEED to see those capabilities just to parse
> them for sane operation.

And that's just not true.

I don't know why you even claim so. There is absolutely *zero* need for
MMCONFIG for 100% of old hardware, and old hardware is exactly the
problem. The hardware that people will run next year isn't the issue.

There may be an absolute need for MMCONFIG for future machines and future
drivers, but there is not a single machine in existence today that really
depends on it. You're just making things up. At worst, you lose some
not-so-important error reporting, no more.

So don't go spreading obvious untruths,

Linus