From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [x86] is checkpatch.pl broken
Date: Wed, 26 Dec 2007 09:44:18 -0800 [thread overview]
Message-ID: <477292F2.7020404@zytor.com> (raw)
In-Reply-To: <aa79d98a0712260238n4848e812l4a66f86b414cc277@mail.gmail.com>
Cyrill Gorcunov wrote:
>
>>
> It's a quite true, sorry for this and thanks for the note. And Peter,
> the line I marked
> is not to be splitted even having additional spaces over math operators. Look
>
> orig:
> mbr_base = (buf_base+sector_size-1) & ~(sector_size-1);
> new (could be):
> mbr_base = (buf_base + sector_size - 1) & ~(sector_size - 1);
>
> Is a new version that bad?
Certainly isn't any better.
-hpa
next prev parent reply other threads:[~2007-12-26 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-25 17:07 [x86] is checkpatch.pl broken Cyrill Gorcunov
2007-12-25 23:47 ` H. Peter Anvin
2007-12-25 23:48 ` H. Peter Anvin
2007-12-26 10:38 ` Cyrill Gorcunov
2007-12-26 17:44 ` H. Peter Anvin [this message]
2007-12-26 18:15 ` Cyrill Gorcunov
2007-12-30 17:22 ` Ingo Molnar
2007-12-30 18:26 ` Cyrill Gorcunov
2007-12-30 20:27 ` H. Peter Anvin
2007-12-31 7:46 ` Cyrill Gorcunov
2007-12-30 20:59 ` Cyrill Gorcunov
2007-12-30 21:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477292F2.7020404@zytor.com \
--to=hpa@zytor.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox