public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: geert@linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS
Date: Mon, 29 Mar 2021 12:32:52 -0400	[thread overview]
Message-ID: <4773905.PvQZvdar3e@ubuntu-mate-laptop> (raw)
In-Reply-To: <87lfa7ved3.fsf@linux-m68k.org>

On Sunday, March 28, 2021 5:04:08 AM EDT you wrote:
> On Mär 28 2021, Julian Braha wrote:
> 
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 2779c29d9981..8d53ed423899 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -1665,7 +1665,7 @@ config LATENCYTOP
> >  	depends on DEBUG_KERNEL
> >  	depends on STACKTRACE_SUPPORT
> >  	depends on PROC_FS
> > -	select FRAME_POINTER if !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
> > +	select FRAME_POINTER if MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
> 
> That doesn't look correct.  It reverses the condition without reversing
> the result, which means the result is probably the opposite than intended.
> 
> The same expression occurs two more times in this file.  Do those need
> to be changed as well?
> 
> Andreas.
> 
> 

Hi all,

This was a mistake - I'll resubmit the proper patch. 
Also: yes, the other usages of this select expression in this file
will cause more unmet dependency bugs. 
I'll include those in the resubmission as well.

- Julian Braha




      reply	other threads:[~2021-03-29 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28  4:13 [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS Julian Braha
2021-03-28  8:45 ` Geert Uytterhoeven
2021-03-28  9:04 ` Andreas Schwab
2021-03-29 16:32   ` Julian Braha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4773905.PvQZvdar3e@ubuntu-mate-laptop \
    --to=julianbraha@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox