The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: Kees Cook <kees@kernel.org>,
	linux-hardening@vger.kernel.org,  Arnd Bergmann <arnd@kernel.org>,
	dm-devel@lists.linux.dev,  linux-kernel@vger.kernel.org,
	Alasdair Kergon <agk@redhat.com>,
	 Benjamin Marzinski <bmarzins@redhat.com>,
	 Mike Snitzer <snitzer@kernel.org>
Subject: Re: [PATCH next] drivers/md/dm-zoned-metadata: User strscpy() to copy device name
Date: Mon, 8 Jun 2026 16:19:25 +0200 (CEST)	[thread overview]
Message-ID: <4773c74f-5425-76fa-dc3a-5a5cf59f4e62@redhat.com> (raw)
In-Reply-To: <20260606202633.5018-12-david.laight.linux@gmail.com>

Hi

I accepted the patch.

Mikulas


On Sat, 6 Jun 2026, david.laight.linux@gmail.com wrote:

> From: David Laight <david.laight.linux@gmail.com>
> 
> Signed-off-by: David Laight <david.laight.linux@gmail.com>
> ---
> This is one of a group of patches that remove potentially unbounded
> strcpy() calls.
> 
> They are mostly replaced by strscpy() or, when strlen() has just been
> called, with memcpy() (usually including the '\0').
> 
> Calls with copy string literals into arrays are left unchanged.
> They are safe and easily detected as such.
> 
> The changes were made by getting the compiler to detect the calls and
> then fixing the code by hand.
> 
> Note that all the changes are only compile tested.
> 
> Some Makefiles were changed to allow files to contain strcpy().
> As well as 'difficult to fix' files, this included 'show' functions
> as they really need to use sysfs_emit() or seq_printf().
> 
> All the patches are being sent individually to avoid very long cc lists.
> Apologies for the terse commit messages and likely unexpected tags.
> (There are about 100 patches in total.)
> 
>  drivers/md/dm-zoned-metadata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
> index ec605acddd88..f4f81c79a080 100644
> --- a/drivers/md/dm-zoned-metadata.c
> +++ b/drivers/md/dm-zoned-metadata.c
> @@ -2871,7 +2871,7 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev,
>  	if (!zmd)
>  		return -ENOMEM;
>  
> -	strcpy(zmd->devname, devname);
> +	strscpy(zmd->devname, devname);
>  	zmd->dev = dev;
>  	zmd->nr_devs = num_dev;
>  	zmd->mblk_rbtree = RB_ROOT;
> -- 
> 2.39.5
> 


      reply	other threads:[~2026-06-08 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-06 20:26 [PATCH next] drivers/md/dm-zoned-metadata: User strscpy() to copy device name david.laight.linux
2026-06-08 14:19 ` Mikulas Patocka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4773c74f-5425-76fa-dc3a-5a5cf59f4e62@redhat.com \
    --to=mpatocka@redhat.com \
    --cc=agk@redhat.com \
    --cc=arnd@kernel.org \
    --cc=bmarzins@redhat.com \
    --cc=david.laight.linux@gmail.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox