From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFFE2156256; Fri, 31 May 2024 12:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=208.88.110.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717159645; cv=none; b=d+wDDs+Fl8+c6aMuaD1jdU/DcIRXQVPo6KBmUzMpADpAnjuOwsMLF9Woe4e2aoGiEL3dJ5Mf0zcjNkCWD35H/0pac+qlPx26CbzSHhNIn4PCimxf1+V/sm5FqsGhBKeOE0H3TWwvGV8342pdXdlP9VDVzEjTfBXLOceF/8OixeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717159645; c=relaxed/simple; bh=SBf8+jOuywRaezyxYyKLbzW9z3O7DhhdigY77jay4Wo=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=ho7PA9rPcHggINf2cI6KT+NGF4S5Ca64IlL9Asv5PTyoOgk19omw7m9nC8+N15j6Ipi95i0bCIq2NDl1CJ+B4X0tVoSSj6Aqbwly4RTontwfhqKdQvtHU9ZNS4qytrMb6rbquKBWTj40VuZYy7dgrrQKrWyVqk7iIrmFTFh+QGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=savoirfairelinux.com; spf=pass smtp.mailfrom=savoirfairelinux.com; dkim=pass (2048-bit key) header.d=savoirfairelinux.com header.i=@savoirfairelinux.com header.b=FzJMj/lB; arc=none smtp.client-ip=208.88.110.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=savoirfairelinux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=savoirfairelinux.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=savoirfairelinux.com header.i=@savoirfairelinux.com header.b="FzJMj/lB" Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id E16039C096E; Fri, 31 May 2024 08:47:22 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id RoyjbGfD5dWH; Fri, 31 May 2024 08:47:22 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 5C8FF9C57BB; Fri, 31 May 2024 08:47:22 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com 5C8FF9C57BB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1717159642; bh=EgSdYLrxxil3DM2ZfEl9AZaBLurlfnS7atm+wMgVU5M=; h=Date:From:To:Message-ID:MIME-Version; b=FzJMj/lBQgsaylMZozyQI2kIuLdeUCa2HURR7HPzGXXXZVlJTOgmNAMKseJ2KzE0e j+LJ0vqdOFwvAfgJvmAh6/1qIre+43sFCrAVETVmoS971gpKsOryyb3kPVx9pr5xKI 5lQnazBd19NEpCjTdgkIF5rU6fAUAGcEa5ISXITdEkGEFregawm7Sto3AwQE0W4wjk XMmxUw46cr1Ec/RiCHKwDDSHhIJ+YhSIInROB0kSDCCCbCfM+5/txtbKhbo1wFuM12 OmcgGSObwusX8pOV4FXRcKXLsb+He224rFMi976Vn2s+tQiLILQIK5h3Ia3xOO8TiG 7/7/A26s54wKw== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id 30jGWh-XiV8C; Fri, 31 May 2024 08:47:22 -0400 (EDT) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [192.168.48.237]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 2911D9C096E; Fri, 31 May 2024 08:47:22 -0400 (EDT) Date: Fri, 31 May 2024 08:47:22 -0400 (EDT) From: Elinor Montmasson To: Mark Brown Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , shengjiu wang , Xiubo Lee , Fabio Estevam , Nicolin Chen , Jaroslav Kysela , Takashi Iwai , linux-sound , devicetree , linux-kernel , alsa-devel , linuxppc-dev Message-ID: <477405270.701257.1717159642136.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: References: <20240515135411.343333-1-elinor.montmasson@savoirfairelinux.com> <20240515135411.343333-9-elinor.montmasson@savoirfairelinux.com> <20d8eb96-6346-4341-95ee-74729001c01a@sirena.org.uk> <1607626951.349332.1715936738428.JavaMail.zimbra@savoirfairelinux.com> Subject: Re: [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC112 (Linux)/8.8.15_GA_4581) Thread-Topic: ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out" Thread-Index: fy+ROOUy4SJ9oY7KJCX4xYYvCNq6Yw== From: "Mark Brown" Sent: Friday, 17 May, 2024 13:06:03 > On Fri, May 17, 2024 at 05:05:38AM -0400, Elinor Montmasson wrote: > >> This new compatible is intended to be used when there is no codec >> device/driver. There is technically no codec device/driver for which >> the clock input can be set. > > This is obviously not true, there clearly is a driver. > >> Is it a bad idea to allow setting the cpu sysclk direction only ? >> Should the compatible be limited to use-cases where the cpu sysclk >> direction cannot be set by the machine driver ? > > When I said "this should use the clock bindings" I meant that we should > use the clock bindings for configuration here. As far I as know, it's not possible to set the direction with the clock bindings, but maybe there is and I missed something ?