From: KaiGai Kohei <kaigai@ak.jp.nec.com>
To: James Morris <jmorris@namei.org>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
akpm@osdl.org, morgan@kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Exporting capability code/name pairs
Date: Fri, 28 Dec 2007 16:33:38 +0900 [thread overview]
Message-ID: <4774A6D2.9090300@ak.jp.nec.com> (raw)
In-Reply-To: <Xine.LNX.4.64.0712281748240.18737@us.intercode.com.au>
James Morris wrote:
> On Fri, 28 Dec 2007, KaiGai Kohei wrote:
>
>> + snprintf(tmp, sizeof(tmp),
>> + cap_entry == &cap_entries[0] ? "0x%08x" : "%u",
>> + cap_entry->code);
>> + len = strlen(tmp);
>
> You don't need to call strlen(), just use scnprintf() and grab the return
> value.
Thanks for your suggestion,
I'll fix it on the next posting.
--
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai@ak.jp.nec.com>
next prev parent reply other threads:[~2007-12-28 7:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-27 3:53 [PATCH] Exporting capability code/name pairs KaiGai Kohei
2007-12-27 7:54 ` James Morris
2007-12-27 16:14 ` Serge E. Hallyn
2007-12-28 1:47 ` KaiGai Kohei
2007-12-28 6:16 ` KaiGai Kohei
2007-12-28 6:54 ` James Morris
2007-12-28 7:33 ` KaiGai Kohei [this message]
2007-12-28 9:12 ` James Morris
2008-01-02 8:04 ` KaiGai Kohei
2008-01-02 10:02 ` James Morris
2008-01-04 2:28 ` KaiGai Kohei
2007-12-28 23:07 ` Randy Dunlap
2007-12-30 16:28 ` Andrew Morgan
2008-01-02 8:08 ` KaiGai Kohei
2008-01-03 1:48 ` Andrew Morgan
2008-01-04 1:57 ` KaiGai Kohei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4774A6D2.9090300@ak.jp.nec.com \
--to=kaigai@ak.jp.nec.com \
--cc=akpm@osdl.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox