From: Masami Hiramatsu <mhiramat@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: Introduce REX prefix helper for kprobes
Date: Sun, 30 Dec 2007 03:31:09 -0500 [thread overview]
Message-ID: <4777574D.8010801@redhat.com> (raw)
In-Reply-To: <47775062.4070300@redhat.com>
Masami Hiramatsu wrote:
> (in case of CONFIG_X86_64)
> static inline int is_rex_prefix(int op)
Oops, s/int op/kprobe_opcode_t opcode/
> About the name, I just used the previous inline function name.
I re-think "is_REX_prefix" is better, because it is an architecture
dependent notation(intel's software developers manual called it
"REX prefixes"), and there is already is_IF_modifier() function
in arch/x86/kernel/kprobes.c.
Thanks,
Best Regards,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2007-12-30 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 3:26 [PATCH] x86: Introduce REX prefix helper for kprobes Harvey Harrison
2007-12-30 6:35 ` Masami Hiramatsu
2007-12-30 7:04 ` H. Peter Anvin
2007-12-30 8:01 ` Masami Hiramatsu
2007-12-30 8:31 ` Masami Hiramatsu [this message]
2007-12-30 13:19 ` Ingo Molnar
2007-12-30 17:39 ` Harvey Harrison
2007-12-30 13:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4777574D.8010801@redhat.com \
--to=mhiramat@redhat.com \
--cc=ananth@in.ibm.com \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox