From: "H. Peter Anvin" <hpa@zytor.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: tglx@linutronix.de, mingo@redhat.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: asm-x86/msr.h for sanitized headers: clean it or punt it
Date: Sun, 30 Dec 2007 21:51:20 -0800 [thread overview]
Message-ID: <47788358.5090409@zytor.com> (raw)
In-Reply-To: <200712310045.24069.vapier@gentoo.org>
Mike Frysinger wrote:
> The current asm-x86/msr.h does not actually define anything for (!__KERNEL__
> && __i386__). For x86_64, it fails to build due to u32/u64 types being used.
> Simply not installing the header seems easiest to me. Otherwise, x86_64 will
> need sanitizing and i386 should have things added back, otherwise it's just a
> pointless empty header.
>
> Signed-Off-By: Mike Frysinger <vapier@gentoo.org>
<asm/msr-index.h> is usable from userspace, <asm/msr.h> includes it for
backwards compatibility.
Nothing else is wanted or needed.
-hpa
next prev parent reply other threads:[~2007-12-31 5:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 5:45 asm-x86/msr.h for sanitized headers: clean it or punt it Mike Frysinger
2007-12-31 5:51 ` H. Peter Anvin [this message]
2007-12-31 12:26 ` Andi Kleen
2007-12-31 15:33 ` Mike Frysinger
2007-12-31 16:36 ` Andi Kleen
2007-12-31 18:10 ` Mike Frysinger
2007-12-31 18:15 ` H. Peter Anvin
2007-12-31 18:49 ` Mike Frysinger
2008-01-01 15:47 ` Ingo Molnar
2008-01-02 1:20 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47788358.5090409@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox