From: Tomas Carnecky <tom@dbservice.com>
To: Christer Weinigel <christer@weinigel.se>
Cc: Andy Whitcroft <apw@uk.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] teach checkpatch.pl about list_for_each
Date: Thu, 03 Jan 2008 13:34:45 +0100 [thread overview]
Message-ID: <477CD665.9050102@dbservice.com> (raw)
In-Reply-To: <20071202130335.690a8daf@cw05lap>
Christer Weinigel wrote:
> By the way, what is the consensus on lines over 80 characters?
> checkpatch complains about the following:
>
> WARNING: line over 80 characters
> #762: FILE: drivers/spi/spi_s3c24xx_dma.c:720:
> + printk(KERN_INFO "S3C24xx SPI DMA driver (c) 2007 Nordnav Technologies AB\n");
>
> I can of course break this into:
>
> printk(KERN_INFO "S3C24xx SPI DMA driver (c) 2007 Nordnav "
> "Technologies AB\n");
>
> but in my opinion that becomes more even unreadable. Would it be
> possible to add a special case so that checkpatch ignores long strings
> that go beyond 80 characters? Do you think it is a good idea?
At the top of the file add a #define and use that in the code? Some
drivers define their version/author etc that way and then just
printk(DRIVER_VERSION DRIVER_AUTHOR);
tom
next prev parent reply other threads:[~2008-01-03 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 12:03 [PATCH] teach checkpatch.pl about list_for_each Christer Weinigel
2007-12-02 13:24 ` Arnaldo Carvalho de Melo
2007-12-02 19:47 ` Valdis.Kletnieks
2008-01-03 11:10 ` Andy Whitcroft
2008-01-03 12:26 ` Christoph Hellwig
2008-01-03 12:30 ` Arnaldo Carvalho de Melo
2008-01-03 15:17 ` Benny Halevy
2008-01-03 23:12 ` Christer Weinigel
2008-01-03 11:23 ` pHilipp Zabel
2008-01-03 12:34 ` Tomas Carnecky [this message]
2008-01-03 23:10 ` Christer Weinigel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477CD665.9050102@dbservice.com \
--to=tom@dbservice.com \
--cc=apw@uk.ibm.com \
--cc=christer@weinigel.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox