From: Arjan van de Ven <arjan@linux.intel.com>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 1/3] move WARN_ON() out of line
Date: Thu, 03 Jan 2008 22:06:24 +0100 [thread overview]
Message-ID: <477D4E50.4020004@linux.intel.com> (raw)
In-Reply-To: <1199325569.4497.116.camel@cinder.waste.org>
Matt Mackall wrote:
>
> I hate the do_foo naming scheme (how about __warn_on?), but otherwise:
>
> Acked-by: Matt Mackall <mpm@selenic.com>
after I moved it around based on Olof's work, I've now ended up with
warn_on_slowpath()
>
>> + printk(KERN_WARNING "WARNING: at %s:%d %s()\n",
>> + __FILE__, __LINE__, __FUNCTION__);
>> + dump_stack();
>
> While we're here, I'll mention that dump_stack probably ought to take a
> severity level argument.
125 files changed, 202 insertions(+), 199 deletions(-)
just to get the api change done.
I can hear akpm cringe from here...
>
next prev parent reply other threads:[~2008-01-03 21:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 0:56 [patch 1/3] move WARN_ON() out of line Arjan van de Ven
2008-01-03 1:59 ` Matt Mackall
2008-01-03 21:06 ` Arjan van de Ven [this message]
2008-01-05 2:35 ` Herbert Xu
2008-01-05 18:33 ` Arjan van de Ven
2008-01-03 4:58 ` Olof Johansson
2008-01-03 21:03 ` Arjan van de Ven
2008-01-03 9:25 ` Ingo Molnar
2008-01-03 16:22 ` Arjan van de Ven
2008-01-05 6:42 ` Jeremy Fitzhardinge
2008-01-03 11:20 ` Pekka Enberg
2008-01-05 5:09 ` Dmitri Vorobiev
2008-01-05 6:41 ` Jeremy Fitzhardinge
2008-01-05 18:01 ` Arjan van de Ven
2008-01-05 18:08 ` Arjan van de Ven
2008-01-05 18:37 ` Arjan van de Ven
2008-01-05 18:45 ` Jeremy Fitzhardinge
2008-01-05 20:02 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477D4E50.4020004@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).