Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

Al Boldi
2008-01-06T05:04:59Z

Sam Ravnborg wrote:
> On Sat, Jan 05, 2008 at 11:03:30PM +0200, Adrian Bunk wrote:
> > For kconfig users, "select" is _much_ better than sending them through
> > different menus.
>
> Only if used within the current limitations of Kconfig.
> And that requires you to use select only to select symbols with
> no dependencies.
>
> In this case we do not know if BLOCK is enabled or not.

Good point! How about we solve it like this:

menuconfig USB_STORAGE
tristate "USB Mass Storage support"
- depends on USB && SCSI
+ depends on USB && BLOCK
+ select SCSI

Thanks!

--
Al