Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

Stefan Richter
2008-01-06T11:55:48Z

Randy Dunlap wrote:
> Sam Ravnborg wrote:
>> On Sat, Jan 05, 2008 at 11:03:30PM +0200, Adrian Bunk wrote:
>>> For kconfig users, "select" is _much_ better than sending them
>>> through different menus.
>> Only if used within the current limitations of Kconfig.
>> And that requires you to use select only to select symbols with
>> no dependencies.
>
> Right. One of the main (or maybe even the only) problem(s) is
> that select does not follow dependency chains.
> and that no one works on that problem.
>
>> In this case we do not know if BLOCK is enabled or not.
>
> For Aunt Tillie cases, "select" makes sense. For other cases,
> I'd argue that it makes sense for config users to know when they
> do something that causes an entire subsystem to be added to their
> kernel (like SCSI or NET).

Besides the issue of additional potentially unsatisfied dependencies and
the issue of things being enabled behind the user's back --- there is
another issue which Adrian and Al ignore:

The user who wants to enable usb-storage /has/ to go into the SCSI menu
anyway to answer whether he needs sd, sr, st, sg, command logging...
--
Stefan Richter
-=====-==--- ---= --==-