Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

Stefan Richter
2008-01-06T11:31:19Z

Adrian Bunk wrote:
> On Sun, Jan 06, 2008 at 01:35:21AM +0100, Stefan Richter wrote:
>> instead work on better UIs if you have got
>> trouble with the complexities of the dependencies graph. The graphic
>> UIs including menuconfig currently work best for tree-like dependencies,
>> but the graph isn't a tree. Think about how to present this properly in
>> an UI. The Kconfig files are the wrong place to attack this problem.
>> ...
>
> Duplicating the structure in each UI should be an improvement?
>
> Hardly.

What do you mean?

We have dependency data in the Kconfig files. We have a few different
UIs to them. Why there are different UIs is easy (oldconfig vs.
xconfig) or not so easy (gconfig vs. xconfig) to explain. Anyway; IMO
we should keep data and presentation separate for at least two reasons:
- to allow us to have specialized task-oriented UIs (oldconfig,
randconfig et cetera)
- because different people have different approaches to kernel
configuration (the guy who sets up a new box vs. the guy who bought
a new gadget vs. the guy who updates his kernel vs. the control
freak vs. the kernel tester vs...)

If the UIs worked properly, then you won't need separate keywords for
dependency and reverse dependency (depends on vs. select) in the Kconfig
files.

Besides, as Sam has reminded us, the make xyzconfig programs handle the
reverse dependency (select) not correctly yet. They switch on the
selected symbols without caring whether these symbols have dependencies
themselves. Friends of 'select', why don't you fix this bug before you
continue to post patches which select symbols which themselves have
dependencies?
--
Stefan Richter
-=====-==--- ---= --==-