Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

Al Boldi
2008-01-06T17:09:35Z

Stefan Richter wrote:
> Al Boldi wrote:
> > Sam Ravnborg wrote:
> >> And that requires you to use select only to select symbols with
> >> no dependencies.
> >>
> >> In this case we do not know if BLOCK is enabled or not.
> >
> > Good point! How about we solve it like this:
> >
> > menuconfig USB_STORAGE
> > tristate "USB Mass Storage support"
> > - depends on USB && SCSI
> > + depends on USB && BLOCK
> > + select SCSI
>
> Still wrong. SCSI also needs HAS_DMA and SCSI_DMA.

I don't think so. SCSI selects SCSI_DMA, it doesn't depend on it. So it's
safe to select SCSI here, as libata does it the same way.

Thanks!

--
Al