From: Eric Dumazet <dada1@cosmosbay.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Improve scalability of epoll_ctl
Date: Tue, 08 Jan 2008 17:26:03 +0100 [thread overview]
Message-ID: <4783A41B.1090100@cosmosbay.com> (raw)
In-Reply-To: <478397F7.1030005@gmail.com>
Changli Gao a écrit :
> Replace the epitem rbtree with a dynamic array to get the constant insertion/deletion/modification time of the file descriptors. Reuse the size argument of epoll_create, however the size must be smaller than the max file descriptor number: ether the resource limitation or the compiling time limitation.
>
>
Hum, you should read this :
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.7-rc3/2.6.7-rc3-mm2/broken-out/epoll-uses-rbtrees.patch
Your patch is a revert of this change, it probably wont be accepted.
epoll_ctl() is scalable, since it's O(log2(N)) : With 1 millions files
descriptors, that means less than 20 nodes to lookup in the tree.
In what situation do you think epoll_ctl() performance is bad ?
next prev parent reply other threads:[~2008-01-08 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 15:34 [PATCH] Improve scalability of epoll_ctl Changli Gao
2008-01-08 16:26 ` Eric Dumazet [this message]
2008-01-08 20:30 ` Davide Libenzi
2008-01-08 16:56 ` Andi Kleen
2008-01-09 1:20 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4783A41B.1090100@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox