From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933519AbcIULim (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 07:38:42 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:51752 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754642AbcIULik (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 07:38:40 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: vinod.koul@intel.com, dan.j.williams@intel.com,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        tony@atomide.com
Subject: Re: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC)
Date: Wed, 21 Sep 2016 13:38:02 +0200
Message-ID: <4786368.2BtHOp8jmm@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <bbd248d1-223c-00a9-3d2a-33df085c4f68@ti.com>
References: <20160921102637.24845-1-peter.ujfalusi@ti.com> <7753810.Z3F41qkFaI@wuerfel> <bbd248d1-223c-00a9-3d2a-33df085c4f68@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:BAuya9xQM5aop/4jwx5+LULclAGBu2Gi7ukkJ6cdZBxOTTnK640
 Zad9aP2X+SJL4BE/y4fumIOJ9d2F5/ebWKJYHCyC5klj0cKuYtF8rndxPapQzNxun4+VmFE
 MGrZSTo2Po80dAAeaIowrjy6Qkxm/r1LwABeCoS3znsKd2ERGMZWJxyINYzbwcigzCYa74c
 7KiNQ4QQYODrro9GPI0UA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Ak3w2RRr1+4=:0yK/nJg/xc7x3BYQlNYQfp
 Rac+mvQb+a6kPbqZe+r8IOUES+rtPWqbO1lvVNs9a5LnMghSqWcS6437PGgH+TYuy70Gv3j/+
 hfM+/PDuP9qFCqTfJCCRrnRCMKcH2Aafqa/8RY4jdSaJdJrQDaEB6N1qxPgIe3Lvj18jNhFsd
 RJw9CEYaaV14KGjfj7ObNEX0f7KksGFk8tnXona/VYE8LzrW+zkKcgmf1HwoYbqc057Jk1AeN
 nSEkkP+u6sFWRbeCxoUEHGoj97WQ7TjNv/hNJ7lQCJPp+3IQ6LaDhM/GnZ421xTI+3jtFIKEj
 dz6w9xdc8NUcCHvLOrBwZV2lvBVx8f6onlzNb5rSolWcMaPKzH0Za2oVCxMnXG/+fGMNvRb+E
 Huozpg9tAb99kHwVik9ZnKXouMpIr8zh65kRlopetUMvtOcv7bsD9Knv+FzZXPhQeasE3x44U
 B0GprmWGVYarxnZCVACCw011bCJbEFMD83+lQenL1YRE2nXSL8ECVOpYKfIHCKlfqlKrrPBp5
 9L5oD4ayW5YYkS1X/0f3+ZwLHN/hAyn9ZavY1OftYWslt8/clU7bUhrH3rqP9+sUbttgeD/F1
 hwCWGu81NsyXd5uPAxgQ2DIWJD0L8nJsaGZQ/um3FaZXV4naz7z9caFYfhVwUxrPqGUQr/sJX
 rb+1RPuBG/UPeCs9jeDWYBCvpSqR4SXVFeWs5kYXD9hBInN885mk8c44rg6EvAmjlURCaIrn4
 atbu3NSc+Lc86fAq
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, September 21, 2016 2:07:22 PM CEST Peter Ujfalusi wrote:
> > 
> > I tend to use 'uintptr_t' for the cast instead.
> 
> What about keeping the defines and:
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 3e9606b08340..493fdf30e8b8 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -263,14 +263,19 @@ static const struct edmacc_param dummy_paramset = {
> 
>  #define EDMA_BINDING_LEGACY    0
>  #define EDMA_BINDING_TPCC      1
> +static const u32 edma_binding_type[] = {
> +       [EDMA_BINDING_LEGACY] = EDMA_BINDING_LEGACY,
> +       [EDMA_BINDING_TPCC] = EDMA_BINDING_TPCC,
> +};
> +
>  static const struct of_device_id edma_of_ids[] = {
>         {
>                 .compatible = "ti,edma3",
> -               .data = (void *)EDMA_BINDING_LEGACY,
> +               .data = (void *)&edma_binding_type[EDMA_BINDING_LEGACY],
>         },
>         {
>                 .compatible = "ti,edma3-tpcc",
> -               .data = (void *)EDMA_BINDING_TPCC,
> +               .data = (void *)&edma_binding_type[EDMA_BINDING_TPCC],
>         },
>         {}

You can drop the cast to (void *) here, otherwise looks good.

	Arnd