Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

Paul Mundt
2008-01-11T03:43:23Z

On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote:
> On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote:
> > -#define DEBUG(x,args...) printk(__FUNCTION__ ": " x,##args)
> > +#define DEBUG(x, args...) printk("%s: ", __func__, x, ##args)
>
> Can this really be expected to work when x contains conversions?
>
> How about:
>
> #define DEBUG(x, args...) printk("%s: " x, __func__, ##args)
>
How about throwing out hand-rolled debug printk wrappers for the
brain-damage they are and using the ones the kernel provides instead?

dev_dbg() and pr_debug() both manage to get these semantics right, and
you can even bury the #define DEBUG underneath some Kconfig silliness if
you're the kind of person that leans that way.

Maybe we can just amend checkpatch to delete a patch out of protest if it
introduces printk() wrappers..