* [PATCH wireless/arlan] Replace logical- by bit-and [not found] ` <472248AC.7080201@tiscali.nl> @ 2008-01-10 19:15 ` Roel Kluin 2008-01-10 20:28 ` Randy Dunlap 0 siblings, 1 reply; 6+ messages in thread From: Roel Kluin @ 2008-01-10 19:15 UTC (permalink / raw) To: linville, lkml; +Cc: linux-wireless Totally untested patch below from linus' git tree. The && is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS 0x80 Replace logical and by bit-and Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h index 3ed1df7..7b7498f 100644 --- a/drivers/net/wireless/arlan.h +++ b/drivers/net/wireless/arlan.h @@ -485,7 +485,7 @@ struct arlan_private { #define clearClearInterrupt(dev){\ writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);} #define setPowerOff(dev){\ - writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\ + writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\ writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_ACCESS);} #define setPowerOn(dev){\ writeControlRegister(dev,readControlRegister(dev) & ~(ARLAN_POWER)); } ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH wireless/arlan] Replace logical- by bit-and 2008-01-10 19:15 ` [PATCH wireless/arlan] Replace logical- by bit-and Roel Kluin @ 2008-01-10 20:28 ` Randy Dunlap 2008-01-10 20:48 ` Chuck Ebbert 2008-01-10 22:19 ` Roel Kluin 0 siblings, 2 replies; 6+ messages in thread From: Randy Dunlap @ 2008-01-10 20:28 UTC (permalink / raw) To: Roel Kluin; +Cc: linville, lkml, linux-wireless On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > Totally untested patch below from linus' git tree. The && is incorrect, right? > > from drivers/net/wireless/arlan.h:390: > #define ARLAN_POWER 0x40 > #define ARLAN_ACCESS 0x80 > > Replace logical and by bit-and > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> > --- > diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h > index 3ed1df7..7b7498f 100644 > --- a/drivers/net/wireless/arlan.h > +++ b/drivers/net/wireless/arlan.h > @@ -485,7 +485,7 @@ struct arlan_private { > #define clearClearInterrupt(dev){\ > writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);} > #define setPowerOff(dev){\ > - writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\ > + writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\ eh? How does that help? 0x80 && 0x40 -> 0 0x80 & 0x40 -> 0 so readControlRegister() | (0) ?? Maybe it should be (ARLAN_POWER | ARLAN_ACCESS), but some arlan developer or someone with specs should help here... > writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_ACCESS);} > #define setPowerOn(dev){\ > writeControlRegister(dev,readControlRegister(dev) & ~(ARLAN_POWER)); } or am I sleeping()? --- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH wireless/arlan] Replace logical- by bit-and 2008-01-10 20:28 ` Randy Dunlap @ 2008-01-10 20:48 ` Chuck Ebbert 2008-01-10 21:16 ` Randy Dunlap 2008-01-10 22:19 ` Roel Kluin 1 sibling, 1 reply; 6+ messages in thread From: Chuck Ebbert @ 2008-01-10 20:48 UTC (permalink / raw) To: Randy Dunlap; +Cc: Roel Kluin, linville, lkml, linux-wireless On 01/10/2008 03:28 PM, Randy Dunlap wrote: > On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > >> Totally untested patch below from linus' git tree. The && is incorrect, right? >> >> from drivers/net/wireless/arlan.h:390: >> #define ARLAN_POWER 0x40 >> #define ARLAN_ACCESS 0x80 >> >> Replace logical and by bit-and >> >> Signed-off-by: Roel Kluin <12o3l@tiscali.nl> >> --- >> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h >> index 3ed1df7..7b7498f 100644 >> --- a/drivers/net/wireless/arlan.h >> +++ b/drivers/net/wireless/arlan.h >> @@ -485,7 +485,7 @@ struct arlan_private { >> #define clearClearInterrupt(dev){\ >> writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);} >> #define setPowerOff(dev){\ >> - writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\ >> + writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\ > > eh? How does that help? > > 0x80 && 0x40 -> 0 1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH wireless/arlan] Replace logical- by bit-and 2008-01-10 20:48 ` Chuck Ebbert @ 2008-01-10 21:16 ` Randy Dunlap 2008-01-10 21:28 ` John W. Linville 0 siblings, 1 reply; 6+ messages in thread From: Randy Dunlap @ 2008-01-10 21:16 UTC (permalink / raw) To: Chuck Ebbert; +Cc: Roel Kluin, linville, lkml, linux-wireless Chuck Ebbert wrote: > On 01/10/2008 03:28 PM, Randy Dunlap wrote: >> >> 0x80 && 0x40 -> 0 > > 1 duh. ack. -- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH wireless/arlan] Replace logical- by bit-and 2008-01-10 21:16 ` Randy Dunlap @ 2008-01-10 21:28 ` John W. Linville 0 siblings, 0 replies; 6+ messages in thread From: John W. Linville @ 2008-01-10 21:28 UTC (permalink / raw) To: Randy Dunlap; +Cc: Chuck Ebbert, Roel Kluin, lkml, linux-wireless On Thu, Jan 10, 2008 at 01:16:33PM -0800, Randy Dunlap wrote: > Chuck Ebbert wrote: >> On 01/10/2008 03:28 PM, Randy Dunlap wrote: > >>> >>> 0x80 && 0x40 -> 0 >> >> 1 > > duh. ack. Well it still seems wrong, changing from an "| 1" to an "| 0". Anyone still using Arlan that can verify the proper fix (which I'd guess is changing "&&" to "|")? John -- John W. Linville linville@tuxdriver.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH wireless/arlan] Replace logical- by bit-and 2008-01-10 20:28 ` Randy Dunlap 2008-01-10 20:48 ` Chuck Ebbert @ 2008-01-10 22:19 ` Roel Kluin 1 sibling, 0 replies; 6+ messages in thread From: Roel Kluin @ 2008-01-10 22:19 UTC (permalink / raw) To: Randy Dunlap; +Cc: linville, lkml, linux-wireless, Elmer.Joandi, c.jennings Randy Dunlap wrote: > On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > >> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h >> index 3ed1df7..7b7498f 100644 >> --- a/drivers/net/wireless/arlan.h >> +++ b/drivers/net/wireless/arlan.h >> @@ -485,7 +485,7 @@ struct arlan_private { >> #define clearClearInterrupt(dev){\ >> writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);} >> #define setPowerOff(dev){\ >> - writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\ >> + writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\ > > eh? How does that help? Right, sorry, please ignore my patch. > Maybe it should be (ARLAN_POWER | ARLAN_ACCESS), but some > arlan developer or someone with specs should help here... I have CC'd the previous maintainers ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-01-10 22:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4722453E.2090801@tiscali.nl>
[not found] ` <472248AC.7080201@tiscali.nl>
2008-01-10 19:15 ` [PATCH wireless/arlan] Replace logical- by bit-and Roel Kluin
2008-01-10 20:28 ` Randy Dunlap
2008-01-10 20:48 ` Chuck Ebbert
2008-01-10 21:16 ` Randy Dunlap
2008-01-10 21:28 ` John W. Linville
2008-01-10 22:19 ` Roel Kluin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox