Re: [PATCH 05/11] NFSv4: Add label recommended attribute and NFSv4 flags

Stephen Smalley
2008-02-28T13:56:31Z

On Thu, 2008-02-28 at 12:52 +1100, James Morris wrote:
> On Wed, 27 Feb 2008, David P. Quigley wrote:
>
> > +#define NFS4_MAXLABELLEN 255
>
> I remember raising this before, but I think we need to try and find a
> better way to implement this than always allocating labels of a fixed and
> possibly too-small size.
>
> What about perhaps starting with a statically allocated array of say 64
> bytes (I can't see any labels on my system larger than that), and then
> falling back to a a dynamic allocation of up to 32k if it turns out to be
> too small ? i.e. large labels are a slow path and there is no practical
> limit on label size.

Yes, that would be my preference as well - there shouldn't be any
internal limits on the label size.

--
Stephen Smalley
National Security Agency