From: "Jan Beulich" <jbeulich@novell.com>
To: "Jeremy Fitzhardinge" <jeremy@goop.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Glauber de Oliveira Costa" <glommer@gmail.com>,
"Andi Kleen" <ak@suse.de>, "LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0 of 2] x86: a couple of misc patches
Date: Fri, 11 Jan 2008 08:13:35 +0000 [thread overview]
Message-ID: <4787333F.76E4.0078.0@novell.com> (raw)
In-Reply-To: <patchbomb.1200004569@localhost>
>2. I noticed the _PAGE_PCD|_PAGE_PWT combination being used a lot, so
>I created _PAGE_NOCACHE to wrap them up. asm-x86/fb.h uses plain
>_PAGE_PCD; should it be _PAGE_NOCACHE too?
Setting PCD but not PWT (or the other way around) is yielding not fully
defined behavior (model specific) as per the doc, so it doen't seem to be
too good an idea to use this. However, adding PWT here may not be what
is desirable either (as it'll make the referenced memory UC unconditionally,
whereas WC is generally more desirable here). It would seem to me,
though, that PWT alone would be the better choice in this situation
(despite this also yielding model specific behavior).
Jan
prev parent reply other threads:[~2008-01-11 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 22:36 [PATCH 0 of 2] x86: a couple of misc patches Jeremy Fitzhardinge
2008-01-10 22:36 ` [PATCH 1 of 2] x86: fold _PAGE_GLOBAL into __PAGE_KERNEL Jeremy Fitzhardinge
2008-01-10 22:36 ` [PATCH 2 of 2] x86: use common _PAGE_NOCACHE Jeremy Fitzhardinge
2008-01-11 8:13 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4787333F.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=glommer@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox