Re: [rfc][patch] reimplement nopfn callers with fault

Nick Piggin
2008-01-16T09:03:33Z

On Mon, Jan 14, 2008 at 10:14:46AM +0100, Jes Sorensen wrote:
> Nick Piggin wrote:
> >On Fri, Jan 11, 2008 at 03:40:10PM +0100, Jes Sorensen wrote:
> >>Nick,
> >>
> >>Is this supposed to apply to the latest Linus tree? I applied it here
> >>and the mspec driver lights up in beautiful fireworks :-( I'll give the
> >>-mm tree a try next.
> >
> >Hi Jes,
> >
> >(reply to all this time).
> >
> >It is the BUG_ON(vma->vm_flags & VM_PFNMAP); at the start of __do_fault, by
> >the looks. That should be simply removed. Sorry about that.
>
> Hi Nick,
>
> Ok, I pulled that line and now mspec is working as expected for me.
> I'll throw in an ACK for your patch then.
>
> Acked-by: Jes Sorensen <jes@sgi.com>

Thanks very much for testing that. Given that the concept seems to be
sound, I'll send the patch to -mm.