From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762013AbYAKVf2 (ORCPT ); Fri, 11 Jan 2008 16:35:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759739AbYAKVfU (ORCPT ); Fri, 11 Jan 2008 16:35:20 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:55875 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759387AbYAKVfT (ORCPT ); Fri, 11 Jan 2008 16:35:19 -0500 Message-ID: <4787E114.2030301@garzik.org> Date: Fri, 11 Jan 2008 16:35:16 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Chuck Ebbert CC: linux-kernel , IDE/ATA development list Subject: Re: LIBATA SCSI command validation changed in 2.6.24 References: <4787DFE2.2000504@redhat.com> In-Reply-To: <4787DFE2.2000504@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chuck Ebbert wrote: > commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 changed command validation > to allow short commands in 16-byte CDBs, but it also made checking more > strict. Before the change, a 10-byte SG_IO command could have its length set > to 9 and still work. Now it fails. Not sure if this is a bug, but it has > caused at least one application to fail that used to work (qpxtool.) > > [https://bugzilla.redhat.com/show_bug.cgi?id=428281] Can you get us an example CDB? Its unclear if the hexdump in the bug report is a returned mode page or the CDB or what...? Jeff