* Re: sata_promise driver and 2.6.11 on a MIPS board
[not found] <4789af9e05060613394b1809c3@mail.gmail.com>
@ 2005-06-06 20:49 ` Jeff Garzik
2005-06-06 21:58 ` Jim Ramsay
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2005-06-06 20:49 UTC (permalink / raw)
To: Jim Ramsay; +Cc: linux-ide, Linux Kernel
Jim Ramsay wrote:
> The driver then waits via a wait_for_completion apparently waiting for
> the PCI card to throw an interrupt so it can continue. However, I
> never see this interrupt generated, and the driver code waits forever.
This is a known bug that definitely needs fixing:
(to ATA developers)
Any time an ATA command is issued outside of the SCSI layer, we need to
employ a timer to time out commands.
Since most commands are done within the SCSI layer, which provides a lot
of error handling apparatus, most commands properly time out. The ones
during probe - IDENTIFY DEVICE, set xfer mode, etc. - do not have such a
timer.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sata_promise driver and 2.6.11 on a MIPS board
2005-06-06 20:49 ` sata_promise driver and 2.6.11 on a MIPS board Jeff Garzik
@ 2005-06-06 21:58 ` Jim Ramsay
0 siblings, 0 replies; 2+ messages in thread
From: Jim Ramsay @ 2005-06-06 21:58 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, Linux Kernel
On 6/6/05, Jeff Garzik <jgarzik@pobox.com> wrote:
> Jim Ramsay wrote:
> > The driver then waits via a wait_for_completion apparently waiting for
> > the PCI card to throw an interrupt so it can continue. However, I
> > never see this interrupt generated, and the driver code waits forever.
>
>
> This is a known bug that definitely needs fixing:
>
> (to ATA developers)
> Any time an ATA command is issued outside of the SCSI layer, we need to
> employ a timer to time out commands.
>
> Since most commands are done within the SCSI layer, which provides a lot
> of error handling apparatus, most commands properly time out. The ones
> during probe - IDENTIFY DEVICE, set xfer mode, etc. - do not have such a
> timer.
So is this an issue with the sata_promise.c driver, or the
libata-core.c? Which one should implement the timeout?
What would you suggest as a workaround or a proper fix?
--
Jim Ramsay
"Me fail English? That's unpossible!"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-06 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4789af9e05060613394b1809c3@mail.gmail.com>
2005-06-06 20:49 ` sata_promise driver and 2.6.11 on a MIPS board Jeff Garzik
2005-06-06 21:58 ` Jim Ramsay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox