From: nigel@suspend2.net
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Pavel Machek <pavel@ucw.cz>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH: 2/2] [SERIAL] avoid stalling suspend if serial port won't drain
Date: Mon, 14 Jan 2008 13:40:16 +1100 [thread overview]
Message-ID: <478ACB90.3040709@suspend2.net> (raw)
In-Reply-To: <20080114004959.0f533fef@lxorguk.ukuu.org.uk>
Hi.
Alan Cox wrote:
>>> Is printk() enough for 'we've just lost your data' condition? Maybe we
>>> should abort suspend if we can't drain fifo?
>> No way. Think about this from a users' perspective. No one wants suspend
>> to ram or hibernate functionality that works sometimes and not others.
>> They want it to work reliably so they don't have to worry about their
>> laptop overheating while they're getting on the bus or airplane.
>> Aborting isn't an option.
>
> Dumb question on the printk however - what if the port that is sticking
> is the console - don't we recurse and die ?
I don't know, but I'd argue that we shouldn't die. Things should be as
robust as possible.
Regards,
Nigel
next prev parent reply other threads:[~2008-01-14 2:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 11:51 [PATCH: 1/2] [SERIAL] avoid waking up closed serial ports on resume Russell King
2008-01-08 11:57 ` [PATCH: 2/2] [SERIAL] avoid stalling suspend if serial port won't drain Russell King
2008-01-09 0:06 ` Andrew Morton
2008-01-09 1:29 ` Alan Cox
2008-01-09 8:34 ` Russell King
2008-01-11 10:17 ` Pavel Machek
2008-01-13 22:51 ` nigel
2008-01-14 0:49 ` Alan Cox
2008-01-14 2:40 ` nigel [this message]
2008-01-14 10:04 ` Russell King
2008-01-14 9:46 ` Russell King
2008-01-13 22:56 ` Benjamin Herrenschmidt
2008-01-14 0:29 ` Russell King
2008-01-14 9:04 ` Pavel Machek
2008-01-14 9:35 ` Russell King
2008-01-14 10:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478ACB90.3040709@suspend2.net \
--to=nigel@suspend2.net \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox