Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl

Andi Kleen
2008-01-13T23:09:12Z

On Sunday 13 January 2008 21:32:23 Cyrill Gorcunov wrote:
> This patch converts ioctl call to unlocked_ioctl form with
> explicit big-kernel-lock.

> Also it makes a bit of cleanup
> converting miscdevice structure initialization to C99 form.

First please always send cleanup patches separately. I think you have more
than just the C99 conversion.

Were you even able to compile it? Since ip27 is ia64 only that would need
an IA64 cross compiler or a native ia64 machine.

It's probably better to focus on drivers only that actually build
on x86 :- see http://www.halobates.de/allyes for a compile log
showing all buildable files for x86-64 and i386.

Other than that the patch looks ok to me, but I haven't tried to
compile it either.

-Andi