From: Benny Halevy <bhalevy@panasas.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: rdunlap@xenotime.net, apw@shadowen.org, jschopp@austin.ibm.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Checkpatch.pl failure
Date: Mon, 14 Jan 2008 18:18:09 +0200 [thread overview]
Message-ID: <478B8B41.6060602@panasas.com> (raw)
In-Reply-To: <1200325734.3159.1.camel@localhost.localdomain>
On Jan. 14, 2008, 17:48 +0200, James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> This error:
>
> ERROR: no space before that close parenthesis ')'
> #501: FILE: drivers/scsi/dpt_i2o.c:2299:
> + if (dev_status == 0x02 /*CHECK_CONDITION*/) {
>
> Is definitely wrong. I think it's stripped the comments so now the if
> looks to have a space before the bracket, but stylistically the
> complaint it has errored out for is wrong.
I've seen similar complaints as well and I agree with James that
they seem bogus. I think that the comment should be treated as
part of the grammar and not just stripped out and then you can
even add checks about allowed spacing before and after the comment.
>
> James
next prev parent reply other threads:[~2008-01-14 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 15:48 Checkpatch.pl failure James Bottomley
2008-01-14 16:18 ` Benny Halevy [this message]
2008-01-14 17:10 ` Andy Whitcroft
2008-01-14 19:04 ` Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478B8B41.6060602@panasas.com \
--to=bhalevy@panasas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox