From: Jiri Slaby <jirislaby@gmail.com>
To: Stephen Hemminger <stephen.hemminger@vyatta.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] checkstack: parse architecture correctly
Date: Mon, 14 Jan 2008 20:50:28 +0100 [thread overview]
Message-ID: <478BBD04.1090705@gmail.com> (raw)
In-Reply-To: <20080114111958.58355143@deepthought>
On 01/14/2008 08:19 PM, Stephen Hemminger wrote:
> The checkstack script wouldn't work because it was picking up the
> newline on the end of the output of uname -m.
>
> Also, use a standard perl construct to print error message and
> exit with non-zero error code.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
>
> --- a/scripts/checkstack.pl 2008-01-14 11:09:09.000000000 -0800
> +++ b/scripts/checkstack.pl 2008-01-14 11:09:51.000000000 -0800
[...]
> - print("wrong or unknown architecture\n");
> - exit
> + die "wrong or unknown architecture\"$arch\"\n";
a space before the variable would be good, maybe qq() instead of "" to avoid
backslashing? Also the \n is reduntant there, otherwise you will loose the
file+line info.
prev parent reply other threads:[~2008-01-14 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 19:19 [PATCH 1/2] checkstack: parse architecture correctly Stephen Hemminger
2008-01-14 19:50 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478BBD04.1090705@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox