[PATCH][try #2] checkpatch: clear the report buffer after processing a file

[PATCH][try #2] checkpatch: clear the report buffer after processing a file

[Li Zefan]

When checking multiple files, the report buffer is not cleared
after processing a file, thus the report will be printed again
and again, mixing up with other reports.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

---
 scripts/checkpatch.pl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 579f50f..a88f7a1 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -624,16 +624,15 @@ sub possible {
 
 my $prefix = '';
 
-my @report = ();
 sub report {
 	my $line = $prefix . $_[0];
 
 	$line = (split('\n', $line))[0] . "\n" if ($terse);
 
-	push(@report, $line);
+	push(our @report, $line);
 }
 sub report_dump {
-	@report;
+	our @report;
 }
 sub ERROR {
 	report("ERROR: $_[0]\n");
@@ -670,6 +669,7 @@ sub process {
 	my $signoff = 0;
 	my $is_patch = 0;
 
+	our @report = ();
 	our $cnt_lines = 0;
 	our $cnt_error = 0;
 	our $cnt_warn = 0;
-- 
1.5.3.rc7

Re: [PATCH][try #2] checkpatch: clear the report buffer after processing a file

[Andy Whitcroft]

On Tue, Jan 15, 2008 at 05:45:23PM +0800, Li Zefan wrote:
> 
> When checking multiple files, the report buffer is not cleared
> after processing a file, thus the report will be printed again
> and again, mixing up with other reports.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Yep, this is clearly broken.  Never used it with more than one file.  We
also accumulate the files in the current version.  I'll fix that up as I
merge this.

Thanks for the patch.

-apw